1038933 - Add option to retrieve kgsl memory reports in get_about_memory.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Eric Rahm [:erahm]]

On flame devices we can gather debug info on kgsl graphics memory usage from |/d/kgsl/proc/<pid>/mem|. The full report should be useful for graphics memory usage analysis.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/367

get_about_memory.py will now attempt to retrieve kgsl memory usage files for each process that is using kgsl, the files are stored in the out_dir with the name kgsl_proc_mem. A --no-kgsl-logs flag has be been added to bypass kgsl memory info collection.

Comment 2

[Nicholas Nethercote [inactive]]

The code looks fine, but is this something that should be read by the SystemMemoryReporter?

Comment 3

[Eric Rahm [:erahm]]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> The code looks fine, but is this something that should be read by the
> SystemMemoryReporter?

:BenWa requested an option to get the raw report as well, we have bug 1038921 for the SystemMemoryReporter.

Comment 4

[Nicholas Nethercote [inactive]]

I'm glad bug 1038921 exists, but this still feels like it's unnecessary duplication of function.

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8458213 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/367

I'll give r+, but I'd like you and BenWa to decide if this is really necessary.

Comment 6

[Benoit Girard (:BenWa)]

My understanding was that the memory reporter would give a general breakdown and throw away the other information. The full KGSL report has extra fields that are useful for debugging like the resource ids. They probably are not that useful outside of graphics debugging but the files should also be small and quick to collect.

I say the cost of collecting this information is fairly low but I admit it wont be looked at very often.

Comment 7

[Eric Rahm [:erahm]]

Yes it contains more information than just the byte counts that SystemMemoryReporter will provide.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/B2G/commit/36cd9905eb6cc08be1161a62dfc87b0f89abbf18

Comment 9

[Nicholas Nethercote [inactive]]

Ok, fair enough.