103897 - Selecting the Mail & Newsgroup cat. and then selecting another cat. causes the OK button to become disabled.

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P2)

Description

[Trix Supremo]

If you select the Mail & Newsgroup category in the pref panel and then you
select any other category(like Advanced or Appearance), the OK button becomes
disabled which prevents your from saving your selections.

Comment 1

[Scott MacGregor]

what build were you using Trix? I couldn't reproduce this on my machine using
the 20011009 .9.4 build.

Comment 2

[Srilatha Moturi]

This happens with today's build. Actually the OK button is not disable but if 
you click on OK the preferences dialog does not close.
To reproduce this problem you have to open Mail and Newsgroups preferences pane 
and then go to a different pane and click OK
Error: document.getElementById("mailnewsEnableMapi") has no properties
Source File: chrome://messenger/content/pref-mailnewsOverlay.js Line: 75

I am working on a fix right now.

Comment 3

[Srilatha Moturi]

Adding keyword nsbranch+

Comment 4

[Trix Supremo]

scott, thats the build i was able to verify it on: 20011009 .9.4. built this
morning.  Clicking on the Mail & Newsgroup cat. and click on any other cat.
causes the OK button to fail. was able to duplicate this on all builds actually.
back to the 20011001 test build of Mozilla.

Comment 5

[Srilatha Moturi]

Attachment: patch v1

Comment 6

[racham]

looks good.
r=bhuvan.

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 52803 [details] [diff] [review]
patch v1

sr=sspitzer

Comment 8

[Jaime Rodriguez, Jr.]

tentantive PDT+, pending test plan and testing for regresions on prefs, in all
platforms. if all this done by 8 p.m., pls try and check this in to 094 branch.

Comment 9

[Trix Supremo]

Attachment: Testplan for testing SMAPI pref pane fix

Comment 10

[Trix Supremo]

Posted testplan for testing Srilatha's fix for this bug.  This testplan should
cover all of the basic functions and other regressions.  Testing will cover all
supported windows platforms. Testing status will be posted once available.

Comment 11

[Hong Kwon]

*** Bug 104130 has been marked as a duplicate of this bug. ***

Comment 12

[lchiang]

Great - thanks, Trix.  cc'ing sairuh and scalkins as a fyi for their areas as
well to watch for this fix when it comes in to look at their areas in prefs.

Comment 13

[Trix Supremo]

Srilatha's fix on this test build has been validated on all windows supported
platforms: win98se, nt4.0, win2k, winXP, & winME.  testcases discussed in
attachment plus additional blackbox testing:(interactivity between Netscape Mail
and Browser, writing changed preferences to prefs.js, and verifying
functionality with radio buttons, checkboxes, textboxes, scrollbars, multilist
selectors, etc...)

Comment 14

[grylchan]

Using Trix's Mozilla zip file on Windows NT 4.0:

I ran a quick regression/smoke test on most of the prefs by manually
selecting/changing few of the prefs in these main pref categories
(Appearance,Navigator,Composer,Mail&Newsgroups,Privacy&Security,Advanced,
and my favorite: Offline &Disk Space). Prefs were saved, enabled/disabled,
and worked as expected.

Tried using tab key to cycle through various prefs panels and no problem.


No obvious UI problems.

Tried seting a pref using the browser and then bringing up the pref
panel through composer/messenger and seeing if the prefs were saved
and no problems that I could see.

and tested the actual bug and I was able to Hit Ok button and the
prefs panel did close.

Comment 15

[Scott MacGregor]

no obvious problems here either for me.  I say check it in tonight if you happen
to still be around.

Comment 16

[Tiantian Kong]

Copied Yulian's test result here to support the check in tonight.

Subj:  Re: Build for testing simple Mapi preference bug # 103897 
Date:  10/10/2001 8:23:14 PM Pacific Daylight Time 
From:    [e-mail] (Yulian Chang)
To:    [e-mail] (Trix Supremo)
CC:    [e-mail] (Srilatha Moturi), [e-mail] (Gary Chan), 
[e-mail] (Luke Gottlieb), [e-mail] (Scott MacGregor), 
tiantiankong8/[e-mail] (Tiantian Kong), [e-mail]
 


It works well on my Windows 2000!

Yulian

Comment 17

[Srilatha Moturi]

Checked into the 0.9.4 branch.

Comment 18

[Srilatha Moturi]

*** Bug 104285 has been marked as a duplicate of this bug. ***

Comment 19

[Tiantian Kong]

Checked into 0.9.4 branch

Comment 20

[esther]

Using winxp build 2001-10-15 and linux build 2001-10-16, MacosX 2001-10-15, and
Mac 9.1 build 2001-10-15 this is fixed.  I tested all of the Mail & Newsgroup
preference and then switched from the Mail/News preference to the Advanced
preference and changed the Cache preference.  All the OK's worked.

Comment 21

[esther]

Note, my above verification was on branch builds.  Trix verified on trunk on 10-09.

Comment 22

[esther]

My mistake, Trix didn't verify on Trunk, I misread his comment, so I will reopen
and put vtrunk in keyword.

Comment 23

[Tiantian Kong]

Esther: we mark as fixed even though it's fixed in branch. 

Lisa suggested that we can query all simple MAPI bugs for trunk later on, and
that the vtrunk keyword is not necessary. 

Comment 24

[Tiantian Kong]

Trix:

Pls verify this one. Thx. 

Comment 25

[Trix Supremo]

verified on 2002022703 mozilla & netscape trunk builds