1039048 - EventDispatcher can eat errors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I had a NativeEventListener that was throwing something close enough to an IllegalArgumentException that the EventDispatcher was catching it here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/EventDispatcher.java#169

That lead to the EventDispatcher falling back to using non-Native listeners and complaining that none exist. We should log these errors here (I'm not sure that "type" comment is correct either), and bail if one of them throws (or better yet, don't catch them?)

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Don't eat IllegalArgumentExceptions in dispatchEvent

So is this all we need?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8461770 [details] [diff] [review]
Don't eat IllegalArgumentExceptions in dispatchEvent

Review of attachment 8461770 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, assuming it passes try.

Comment 3

[Brian Nicholson (:bnicholson)]

https://tbpl.mozilla.org/?tree=Try&rev=3a014ee38fd1

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/85877e09c5a8

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85877e09c5a8