Closed Bug 1039175 Opened 5 years ago Closed 5 years ago

"Ignore this warning" button has uncorrect position on about:blocked page with RTL locales

Categories

(Toolkit :: Safe Browsing, defect, trivial)

All
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: seleznev.ru, Assigned: seleznev.ru)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image screenshot.png
Just look on screenshot. It has ltr, rtl and expected (?) parts.

Steps to reproduce:

* Start Firefox build with RTL locale (for ex., ar).

* Try to open "http://www.itisatrap.org/firefox/its-an-attack.html" page.
Attached patch Simple patch (obsolete) — Splinter Review
Attachment #8456680 - Flags: review?(gavin.sharp)
Blocks: 400731
Attachment #8456680 - Flags: review?(gavin.sharp) → review?(ehsan)
Comment on attachment 8456680 [details] [diff] [review]
Simple patch

Review of attachment 8456680 [details] [diff] [review]:
-----------------------------------------------------------------

Looks mostly good, but I have a couple of nits.  Can you please address them and submit a new patch?  Thanks a lot!

::: browser/base/content/blockedSite.xhtml
@@ +143,5 @@
>          font-size: smaller;
>        }
>        
> +      #ignoreWarningButton:-moz-dir(rtl) {
> +        right: 20px;

Nit: please set left to auto as well to override the rule above.

@@ +150,2 @@
>        #ignoreWarning {
>          text-align: right;

Instead of the rule below, you can just convert this to text-align: end.
Attachment #8456680 - Flags: review?(ehsan) → feedback+
I corrected all deficiencies. Many thanks for your feedback.
Attachment #8456680 - Attachment is obsolete: true
Attachment #8459105 - Flags: review?(ehsan)
Comment on attachment 8459105 [details] [diff] [review]
fix-ignore-button-position-r2.patch

Review of attachment 8459105 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8459105 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/36cf96084e12
Assignee: nobody → seleznev.ru
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/36cf96084e12
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.