1039175 - "Ignore this warning" button has uncorrect position on about:blocked page with RTL locales

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Aleksandr Seleznev]

Attachment: screenshot.png

Just look on screenshot. It has ltr, rtl and expected (?) parts.

Steps to reproduce:

* Start Firefox build with RTL locale (for ex., ar).

* Try to open "http://www.itisatrap.org/firefox/its-an-attack.html" page.

Comment 1

[Aleksandr Seleznev]

Attachment: Simple patch

Comment 2

[(no longer active)]

Comment on attachment 8456680 [details] [diff] [review]
Simple patch

Review of attachment 8456680 [details] [diff] [review]:
-----------------------------------------------------------------

Looks mostly good, but I have a couple of nits.  Can you please address them and submit a new patch?  Thanks a lot!

::: browser/base/content/blockedSite.xhtml
@@ +143,5 @@
>          font-size: smaller;
>        }
>        
> +      #ignoreWarningButton:-moz-dir(rtl) {
> +        right: 20px;

Nit: please set left to auto as well to override the rule above.

@@ +150,2 @@
>        #ignoreWarning {
>          text-align: right;

Instead of the rule below, you can just convert this to text-align: end.

Comment 3

[Aleksandr Seleznev]

Attachment: fix-ignore-button-position-r2.patch

I corrected all deficiencies. Many thanks for your feedback.

Comment 4

[(no longer active)]

Comment on attachment 8459105 [details] [diff] [review]
fix-ignore-button-position-r2.patch

Review of attachment 8459105 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/36cf96084e12

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/36cf96084e12