1039220 - [Wifi] Fail to reconnect to WPA-EAP network by manual switch network.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

STR:
1. Open Settings app and enter Wifi section.
2. Connect to any WPA-EAP network A.
3. Connect to another network B.
4. Tap on network A to reconnect.

EXPECTED RESULT:
Disconnect from network B and connect to network A

ACTUAL RESULT:
No wifi action with error message in logcat:
E/wpa_supplicant(  907): Line 0: failed to parse password.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Fix judgement rule for valid property.

The last judge rule is try to ignore password/wep_key0/psk config of value '*'.
So the truth table of valid property should be:
    valid    | is password property |  not password property
-------------+----------------------+-------------------------
 value is *  |          F           |            T
-------------+----------------------+-------------------------
 value not * |          T           |            T

so the valid judgment should be (not password property || value not *), which is wrong in current code.

Comment 2

[Henry Chang [:hchang]]

Comment on attachment 8456766 [details] [diff] [review]
0001. Fix judgement rule for valid property.

Review of attachment 8456766 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks your explanation! It's hard to understand without your truth table :p
By the way, just curious, why does the original condition only result in manually
connecting for WPA-EAP?

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Based on the code, I think it would also fail on manual swtich to network of WPA-PSK and WEP modes.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Chuck Lee [:chucklee] from comment #3)
> Based on the code, I think it would also fail on manual swtich to network of
> WPA-PSK and WEP modes.

The differences between manually switch to WPA-EAP and WPA-PSK/WEP network is how |wifiHelper.setPassword()|[1] is called[2].

While manually connect to a previous-connected-network, the value of network.password is "*".
For WPA-PSK/WEP network, network.psk/network.wep is set to null in wifiHelper.setPassword(), and treated as invalid property in current rule.
For WPA-WEP network, network.password will keep its value "*" and treat as valid property.

But Gaia still need to call wifiHelper.setPassword() in [2] to set correct security method[3] now.

[1] http://git.mozilla.org/?p=releases/gaia.git;a=blob;f=shared/js/wifi_helper.js;h=f37a910677b2a97ce1204379405320bdb3d99cab;hb=HEAD#l13
[2] http://git.mozilla.org/?p=releases/gaia.git;a=blob;f=apps/settings/js/wifi.js;h=ac39c32bea0394d411cea321e7845b85665738e0;hb=HEAD#l750
[3] http://git.mozilla.org/?p=releases/gaia.git;a=blob;f=shared/js/wifi_helper.js;h=f37a910677b2a97ce1204379405320bdb3d99cab;hb=HEAD#l51

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try looks good: https://tbpl.mozilla.org/?tree=Try&rev=7c88015a89ef

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e95389b24a0d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e95389b24a0d

Comment 8

[Gerry Chang [:gchang]]

Verified @
Gaia      b67ddd7d40b52e65199478b8d6631c2c28fdf41d
Gecko     https://hg.mozilla.org/mozilla-central/rev/005424a764da
BuildID   20140730160200
Version   34.0a1