1039326 - [flatfish][settings] overlapping elements

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Benlamara]

Attachment: 2014-07-15-00-29-44.png

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

settings elements are overlapping
FFos 2.1 flatfish_20140626-0139

Comment 1

[Benlamara]

Attachment: 2014-07-15-00-47-55.png

Comment 2

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Chens, is there visual spec regarding the slider?

Comment 4

[Sherman Chen [:chens] (inactive)]

No, I didn't found it, do we have previous spec for slider on tablet that I can reference for?

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Settings_20131105.pdf

Here is the latest tablet spec that I can find. Please adjust the UI based on the spec, thanks.

Comment 6

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request 2

Update settings_large.css based on spec

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469967 [details] [review]
Pull request 2

Thanks for the patch! Please check my comment in github for a few tiny adjustments. And please also increase the width of select elements to make the default drop-down arrow invisible.

Comment 10

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8469967 [details] [review]
Pull request 2

Hi Arthur, 
I have update the pull request based on the comments you shared, could you review this patch? thanks.

Comment 11

[Daniele "Mte90" Scasciafratte]

in this ticket there are other problem with alignment.
i've uploaded the images in the wrong ticket (-.-' too many tabs opened)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469967 [details] [review]
Pull request 2

Sorry for the late review. I thought I've had gave r+ on this one. r=me, thanks!

Comment 13

[Daniele "Mte90" Scasciafratte]

I forget to mention the ticket with my screenshots https://bugzilla.mozilla.org/show_bug.cgi?id=1041313

Comment 14

[Sherman Chen [:chens] (inactive)]

(In reply to Daniele "Mte90" Scasciafratte from comment #13)
> I forget to mention the ticket with my screenshots
> https://bugzilla.mozilla.org/show_bug.cgi?id=1041313

Yep, also notice this, but we have bug 1041313 to track button related issues and we should work on that bug.

Comment 15

[Lavish Aggarwal]

I have generated a pull request https://github.com/mozilla-b2g/gaia/pull/23245

Comment 16

[Sherman Chen [:chens] (inactive)]

Merged to master: 
https://github.com/mozilla-b2g/gaia/commit/bfd676a58d172b16034610f4d274be14c4eee12a