Closed Bug 1039454 Opened 7 years ago Closed 6 years ago

"ASSERTION: Computed overflow area must contain frame bounds" in sequence of style changes

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(2 files)

Attached file test.html
I ran into this while debugging another bug.

The attached testcase fires this assertion on load.
Attached patch fixSplinter Review
Initially the test sets InitialOverflowProperty for 'outer' to have width 300px. In the second step, we FinishAndStoreOverflow for 'outer' and note that we no longer need a real overflow rect since there is no overflow, but the InitialOverflowProperty is not removed or modified so it's still 300px wide. Then in the third step we trigger an UpdateOverflow change which uses the stale value of InitialOverflowProperty and asserts because it doesn't contain the element's border-box.
Attachment #8456834 - Flags: review?(mats)
Comment on attachment 8456834 [details] [diff] [review]
fix

s/Remove/Delete/ otherwise you leak the value, right?

r=mats with that

Also, would it be possible to add MOZ_WARN_UNUSED_RESULT on the
Remove declaration to avoid this in the future?
Attachment #8456834 - Flags: review?(mats) → review+
Er yeah, good point.

(In reply to Mats Palmgren (:mats) from comment #2)
> Also, would it be possible to add MOZ_WARN_UNUSED_RESULT on the
> Remove declaration to avoid this in the future?

Probably. I'll try that.
https://hg.mozilla.org/mozilla-central/rev/9ce2ae3e23f3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.