1039471 - crash in java.lang.IllegalStateException: Fragment RecentTabsPanel{422715c0} not attached to Activity at android.support.v4.app.Fragment.getLoaderManager(Fragment.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

This bug was filed from the Socorro interface and is 
report bp-a680a97d-6f67-4cee-b694-8fb002140716.
=============================================================

Steps to reproduce:
1. Install pocket-panel, goal.com

Expected result:
- Feeds appear in about:home

Actual result:
- Firefox crashes.
Note: 
- not reproducible with instagram, wikipedia, home-feeds.

Stacktrace:
java.lang.IllegalStateException: Fragment RecentTabsPanel{422715c0} not attached to Activity
	at android.support.v4.app.Fragment.getLoaderManager(Fragment.java:863)
	at org.mozilla.gecko.home.RecentTabsPanel$3.run(RecentTabsPanel.java:253)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5001)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Aaron Train [:aaronmt]]

Margaret, is this fallout from bug 1004850?

Comment 2

[Lucas Rocha (:lucasr)]

Looks like a Gecko message is received after the fragment has been detached. Teodora, is this bug reproducible every time you install pocket-panel or goal.com?

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Only restart loader if RecentTabsPanel is still attached (r=margaret)

Comment 4

[Teodora Vermesan (:TeoVermesan)]

Yes, I install goal.com, firefox crashes, after that I go to about:addons and uninstall it, then try once again to install and firefox crashes again.

Comment 5

[:Margaret Leibovic]

Doh, this looks like a regression from bug 1035439.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8456869 [details] [diff] [review]
Only restart loader if RecentTabsPanel is still attached (r=margaret)

Review of attachment 8456869 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/RecentTabsPanel.java
@@ +250,5 @@
>                  mClosedTabs = closedTabs;
>  
> +                // The fragment might have been detached before this code
> +                // runs in the UI thread.
> +                if (getActivity() != null) {

Should we check canLoad() instead? That's what we used to do but changed here:
https://hg.mozilla.org/mozilla-central/rev/81c71f117c6a

Comment 7

[Brian Nicholson (:bnicholson)]

(In reply to :Margaret Leibovic from comment #6)
> Should we check canLoad() instead? That's what we used to do but changed
> here:
> https://hg.mozilla.org/mozilla-central/rev/81c71f117c6a

There was a reason it was removed in bug 1035439; see https://bugzilla.mozilla.org/show_bug.cgi?id=1035439#c11. We still need to refresh the Recent Tabs panel with these STR, which were broken on Nightly before that bug:
1) Open about:home
2) Open a new tab for a different URL (e.g., google.com)
3) Select the tab from step 1
4) Go to the Recent Tabs panel (to load it), then go to another panel (to keep the Recent Tabs panel active, but hidden)
5) Close the tab in step 2, without selecting it
6) Go to the Recent Tabs panel again

canLoad() checks the fragment's visibility, which I don't think is something we should check in this case. We want to update the Recent Tabs panel regardless of whether we see it.

Comment 8

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/12a593a3681d

Comment 10

[Nick Alexander :nalexander [he/him]]

I stumbled over this (race condition?) using the debugger to investigate Bug 1038354; nice to see the fix is already in.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12a593a3681d

Comment 12

[Teodora Vermesan (:TeoVermesan)]

After installing pocket-panel and goal.com, feeds appear in about:home, so:
Verified fixed on:
Device: LG Nexus 4 
OS: Android 4.4.2
Build: Firefox for Android 33.0a1 (2014-07-20)