Closed Bug 1039493 Opened 6 years ago Closed 6 years ago

Move debugger shell/settings to separate files

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

Debugging code is cluttering up shell.js and settings.js.  We can break this out into its own files.

Bug 942756 attachment 8415789 [details] [diff] [review] made an attempt at this, but the bug hasn't been updated for a while.
Summary: Move debugger to separate files → Move debugger shell/settings to separate files
Fabrice, I'm moving the DevTools related bits out of shell.js and settings.js.

Also, if it's okay with you, I thought it might be safe to only need DevTools peer review for future changes to the files in the new b2g/chrome/content/devtools directory, just to lighten the review burden.  Either way, whatever's best for you.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e29dd8dd3f52
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8474829 - Flags: review?(fabrice)
Attachment #8474829 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/63aa6e5dd802
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
This breaks the screenreader, it is no longer activateable.
Depends on: 1056205
(In reply to Eitan Isaacson [:eeejay] from comment #4)
> This breaks the screenreader, it is no longer activateable.

Sorry for the breakage.  Looks like you've got a fix underway already.
You need to log in before you can comment on or make changes to this bug.