1039493 - Move debugger shell/settings to separate files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Debugging code is cluttering up shell.js and settings.js.  We can break this out into its own files.

Bug 942756 attachment 8415789 [details] [diff] [review] made an attempt at this, but the bug hasn't been updated for a while.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Break out b2g DevTools files

Fabrice, I'm moving the DevTools related bits out of shell.js and settings.js.

Also, if it's okay with you, I thought it might be safe to only need DevTools peer review for future changes to the files in the new b2g/chrome/content/devtools directory, just to lighten the review burden.  Either way, whatever's best for you.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e29dd8dd3f52

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/63aa6e5dd802

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/63aa6e5dd802

Comment 4

[Eitan Isaacson [:eeejay]]

This breaks the screenreader, it is no longer activateable.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> This breaks the screenreader, it is no longer activateable.

Sorry for the breakage.  Looks like you've got a fix underway already.