1039497 - Mortar: Update TabView template install library

Status: RESOLVED FIXED

(Developer Ecosystem :: Dev Kit, defect)

Description

[Soledad Penades [:sole] [:spenades]]

It uses an early version of https://github.com/sole/mortar-appinstall, should use a newer one

Comment 1

[Trishul]

If you could guide me a bit, I would love to work on this bug.

Comment 2

[Soledad Penades [:sole] [:spenades]]

Hey Trishul, thanks for the offer! This is wonderful.
Let me fix a couple of details in that library and I'll ping you again with instructions.
I will mark you as "needinfo" then.

Pinging you soon... :)

Comment 3

[Soledad Penades [:sole] [:spenades]]

Hello again!

I finished fixing the details in AppInstall.

The latest version is here https://github.com/mozilla/mortar-appinstall/tree/master/src
It basically needs to be put in https://github.com/mozilla/mortar-tab-view/tree/master/js/lib

and then make sure it works (being able to detect if the environment can run installations, hide or show the install button according to that and if the app is already installed, if not make sure that installing the app works).

I think there were no API changes from the old to the new version but if it doesn't instawork that might be one of the reasons :D

Let me know if you need more help!

Comment 4

[Trishul]

Hi Sole,

I have replaced the AppInstall.js and tested the tab-view, the install button is behaving as expected.
here is the PR
https://github.com/mozilla/mortar-tab-view/pull/11

Comment 5

[Trishul]

If everything is perfect then please assign this bug and mark it resolved :)

Comment 6

[Soledad Penades [:sole] [:spenades]]

Super fixed by this AND https://github.com/mozilla/mortar-appinstall/commit/a8298183241460fb6f6c6439d568387dff16cfe1 :-)

Thanks a lot, Trishul!