1039577 - CrashReporter::OOPInit should be multithread-safe

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Benjamin Smedberg]

Currently CrashReporter::OOPInit assumes that it's called from the main thread, but in the case of GMP plugins that's no longer true. The patch I will attach shortly synchronously proxies the work to the main thread.

I believe that the rest of the code is already threadsafe; it's used from the IPC thread and others already.

Comment 1

[Benjamin Smedberg]

Attachment: bug1039577-OOPInit

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8456971 [details] [diff] [review]
bug1039577-OOPInit

Review of attachment 8456971 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/crashreporter/nsExceptionHandler.cpp
@@ +2561,1 @@
>    if (OOPInitialized())

There shouldn't be any risk of races here if this is called from multiple background threads because they'll be serialized on the main thread, right?

Comment 3

[Benjamin Smedberg]

Correct, the proxy to the main thread is the inherent synchronization.

Comment 4

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb0e9c6c148

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fcb0e9c6c148