1039610 - Facebook in-Contacts app approval screen is too long and not scrollable

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Anthony Ricaud (:rik)]

Attachment: facebook-approval.png

Without having synced your FB contacts,
STR:
1) Open Contacts app
2) Open Settings
3) Click Sync Friends
4) Enter your credentials

Expected:
I can allow Firefox OS to access my contacts

Actual:
The view is too long to click the OK button and can't be scrolled. See screenshot

I've reproduced this on a Flame and on an Hamachi.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Hi Didem,

not sure it you are the right person to ping about Facebook, this error looks to me like FB login page is not completely mobile friendly (at least our mobile).

Do you know who we need to ping in FB to check this?

Comment 3

[Didem Ersoz [:didem]]

Hi Francisco, 

I cc'ed Harald from PE. We'll have a look at this bug and inform Facebook. Thanks.

Comment 4

[Nicole Fong]

When I tested this bug, I never received the notification like the picture attached.  It just went straight to all my Facebook contacts.

Comment 5

[Didem Ersoz [:didem]]

I have tested it on my Flame device, and I never received the notification in the attached picture either. It went to my Facebook contacts and prompted me to select which ones I want to import.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Generally if you have already given Facebook your permission it won't ask you again. You'll have to log in to Facebook on desktop, go to your settings there, and remove "Firefox OS" from the list of apps that are allowed to access your info. You should then get this prompt again the next time you try to import contacts.

Comment 7

[Didem Ersoz [:didem]]

Attachment: Facebook_contact_sync_test.png

Yes, I already re-tested the app after I revoked the FxOS access in Facebook. The page asking permission perfectly displayed the "OK" button, see the attached screen shot. 

To sum up, we can not reproduce the issue.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

I am still able to reproduce the issue. I flashed the build at [1] onto my Flame device, booted it up, set up a Wi-Fi network, and then tried to sync FB contacts. After entering my Facebook credentials (I previously removed Firefox OS from the list of FB apps, as I described in comment 6), I end up on a screen like the one attached, and can't click on the buttons.

Since I seem to be able to reproduce this easily, if there's any investigation you would like me to do please let me know.

[1] https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/tinderbox-builds/mozilla-central-flame-eng/20140728065013/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Interestingly, comparing the two screenshots shows that the "Facebook" title is centered in the page I get but not in the one you get. That bit should be rendered in Gaia, right? Was that fixed recently? Or is that an indicator of some other bug or discrepancy?

Comment 10

[:Harald Kirschner :digitarald]

What is the output from https://github.com/Mozilla-TWQA/B2G-flash-tool/blob/master/check_versions.sh for your device? If you can't get that, post the details from Settings > Device Information.

Comment 11

[:Harald Kirschner :digitarald]

Hopefully Kartikaya can provide the same.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

kats@kgupta-pc B2G-flash-tool$ ./check_versions.sh
Gaia      295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko     https://hg.mozilla.org/mozilla-central/rev/d77f6a96ff96
BuildID   20140728065013
Version   34.0a1
ro.build.version.incremental=eng.cltbld.20140728.101433
ro.build.date=Mon Jul 28 10:14:42 EDT 2014

Comment 13

[:Harald Kirschner :digitarald]

Looks like a freshly build 2.1. Just to confirm, did you use the v123 base image and only flash gecko & gaia?

Comment 14

[Kartikaya Gupta (email:[e-mail])]

I ran the flash.sh script from the flame.zip file at https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/tinderbox-builds/mozilla-central-flame-eng/20140728065013/

I don't know if that updates the base image or not, and what the last base image I loaded on there was.

Comment 15

[Anthony Ricaud (:rik)]

I can't reproduce anymore with updated Gecko and Gaia. The window is scrolled down though. I can't see the blue Facebook header. (only when I overscroll)

Comment 16

[Didem Ersoz [:didem]]

Anthony thank you for your update. 

Kartikaya, it looks like the issue is specific to the build you have on your phone now, not caused by Facebook. The issue can not be reproduced on the reference device. I'll close this bug.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Nothing was fixed, so the appropriate status is WFM.

Comment 18

[Didem Ersoz [:didem]]

thanks for the correction.

Comment 19

[Didem Ersoz [:didem]]

Kartikaya, could you try these steps, this should solve the problem on your flame: 

1) Start with a v123 base build 
2) And only flash gecko & gecko from there on

hope this works for you. 

thanks.

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Thanks for the suggestion. However I only needed to access that OK button for the purpose of testing another bug. I'm fine with leaving things as they are if it's just me that's affected.