1039658 - "Graph" tab for ADU by Signature yields Error while loading data text status: error error: BAD REQUEST

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: bad-request.png

STR:

1. From the homepage, choose "Explosive Crashes" for Firefox (https://crash-stats.allizom.org/explosive/products/Firefox)
2. Click on "_moz_cairo_destroy" (https://crash-stats.allizom.org/report/list?signature=_moz_cairo_destroy&date=2014-07-14&range_value=1&range_unit=days)
3. Now, click on the "Graph" tab

Likely this is because of the GET request that's a 400:

https://crash-stats.allizom.org/adu_by_signature/json_data?product_name=Firefox&signature=_moz_cairo_destroy&

Comment 1

[Peter Bengtsson [:peterbe]]

Was it right to assign this to you Schalk?

Comment 2

[Schalk Neethling [:espressive]]

(In reply to Peter Bengtsson [:peterbe] from comment #1)
> Was it right to assign this to you Schalk?

Yep, this is fine.

Comment 3

[Schalk Neethling [:espressive]]

I cannot reproduce this anymore, not on stage, local or prod. Currently I either get something like 'No data returned for signature _moz_cairo_destroy' or 'Insufficient data to draw graph' but not a 500 error.

Stephen, did you just click through or, did you change anything in the URL?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Schalk Neethling [:espressive] from comment #3)
> I cannot reproduce this anymore, not on stage, local or prod. Currently I
> either get something like 'No data returned for signature
> _moz_cairo_destroy' or 'Insufficient data to draw graph' but not a 500 error.
> 
> Stephen, did you just click through or, did you change anything in the URL?

It's a 400 BAD REQUEST, actually, not an Internal Server Error/500.  Yup, can still reproduce it - please see http://screencast.com/t/OndWOSiAhE

Comment 5

[Schalk Neethling [:espressive]]

(In reply to Stephen Donner [:stephend] from comment #4)
> (In reply to Schalk Neethling [:espressive] from comment #3)
> > I cannot reproduce this anymore, not on stage, local or prod. Currently I
> > either get something like 'No data returned for signature
> > _moz_cairo_destroy' or 'Insufficient data to draw graph' but not a 500 error.
> > 
> > Stephen, did you just click through or, did you change anything in the URL?
> 
> It's a 400 BAD REQUEST, actually, not an Internal Server Error/500.  Yup,
> can still reproduce it - please see http://screencast.com/t/OndWOSiAhE

Yep, I mistyped ;p Back to the drawing board to try and repro. Thanks Stephen

Comment 6

[Schalk Neethling [:espressive]]

Pull request: https://github.com/mozilla/socorro/pull/2244

Testing
--------

Steps to verify are slightly different than in comment 1 (the screen recording actually demonstrates the problem better)

1. From the homepage, choose "Explosive Crashes" for Firefox (https://crash-stats.allizom.org/explosive/products/Firefox)
2. Click on "_moz_cairo_destroy" (https://crash-stats.allizom.org/report/list?signature=_moz_cairo_destroy&date=2014-07-14&range_value=1&range_unit=days)
3. Now, click on the "Graph" tab
4. Switch to a different tab than "Graph", say reports
5. Hit reload
6. At this point switching back to the "Graph" tab will show the error described.

After the PR above lands, there should be no error at step 6.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6d0ac6f37939ea6a520f4ba95da18d1897d4056f
Fix Bug 1039658, loading report list with graph tab not active causes 400 bad request

https://github.com/mozilla/socorro/commit/7caa65806dfe3319f94a8182628a1c56b42b180c
Merge pull request #2244 from ossreleasefeed/bug1039658-report-list-graph-500-from-explosive-crashes

Fix Bug 1039658, loading report list with graph tab not active causes 400 bad request

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/report/list?signature=_moz_cairo_destroy&date=2014-07-14&range_value=1&range_unit=days#tab-graph - thanks, Schalk!

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screen Shot 2014-07-25 at 3.39.04 PM.png

Post-fix screenshot (staging)