1039820 - "TypeError: content is null" (in tab-events.js)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Matteo Ferretti [:zer0] [:matteo]]

For example, executing `test-panel` logs a lot of the following lines:

System JS : ERROR resource://extensions.modules.b8c0dbc8-1668-4930-b6a9-3468ce16447f-at-jetpack.commonjs.path/framescript/tab-events.js:40 - TypeError: content is null
console.log: addon-sdk: [JavaScript Error: "content is null" {file: "resource://extensions.modules.b8c0dbc8-1668-4930-b6a9-3468ce16447f-at-jetpack.commonjs.path/framescript/tab-events.js" line: 40}]

However the test itself pass.
Given the file's source I believe depends by the recently introduced framescript.

Comment 1

[Tomislav Jovanovic :zombie]

looked quickly into this, it's simple to fix, but i wanna investigate more to find out the cause, and since it's not breaking anything, it doesn't look like a priority, so i'll likely get to it next week.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

I see this constantly even when just navigating and using the browser.

Comment 4

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1657

the problem here was the usage of chromeEventListener, which :smaug advises against, as it can have a slightly different lifetime from TabChild (the implied `this` that is now used to listen for 'pageshow' events).

i also took the opportunity to clean up/simplify some other code..

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8495923 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1657

Looks good to me! r+ with all tests passing, and possibly with the nit in the PR comment addressed.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/5f952e1f8968a0626c7ba9ac14fdd1ef7ed89680
bug 1039820 - avoid using chromeEventHandler in framescript

https://github.com/mozilla/addon-sdk/commit/974d800f18f7262d28da660c5e43775a26398516
Merge pull request #1657 from zombie/1039820-fs-chromeEventHandler

bug 1039820 - avoid using chromeEventHandler in framescript, r=@ZER0