1039904 - Changing the URL in a pinned tab opens new tab instead

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[matthias koplenig [:metasieben]]

For the last few Nightlies I have been unable to change the URL in an App-tab, instead a new tab is created at the end of the Tabstrip.

Even pressing Enter, without changing the URL opens a new tab.

Comment 1

[Matthew N. [:MattN]]

I can't reproduce this on today's Nightly on OS X. Can you try reproduce this in safe mode[1]? I suspect it's caused by an extension.

[1] https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 2

[matthias koplenig [:metasieben]]

Not only am I able to reproduce it in safe-mode, but also with a new profile.

STR.
[1] open several tabs add some app-tabs(eg. http://planet.mozilla.org/?abc )
[2] set session-restore to >Show my windows and tabs from last time<
[3] restart browser.
[4] change url of app-tab to http://planet.mozilla.org/?abcdef

result: instead of simply opening the url, Nightly opens a new tab, at the end of the tab-strip.

Comment 3

[matthias koplenig [:metasieben]]

The last working mozilla-central build is from 2014-07-11(rev:e1a037c085d1), the next one (rev: b0701d069bf9), at least for me, doesn't.

Comment 4

[Paul Silaghi, QA [:pauly]]

Confirmed in 33.0a1 (2014-07-20), Win 7 using the STR in comment 2

Comment 5

[:Gijs (he/him)]

[Tracking Requested - why for this release]: This was merged up yesterday, and is a recent regression of core functionality.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e1a037c085d1&tochange=b0701d069bf9

The best I can think of here is bug 1034845... Dão, is it just me or would this be caused by the loadURI vs. openUILinkIn switch in loadCurrent in urlbarBindings.xml ? (not entirely sure why yet, but it seems plausible...)

Comment 6

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch (PTO july 17-21) from comment #5)
> The best I can think of here is bug 1034845... Dão, is it just me or would
> this be caused by the loadURI vs. openUILinkIn switch in loadCurrent in
> urlbarBindings.xml ?

yes

Comment 7

[Marco Mucci [:MarcoM]]

Waiting on feedback from GMC if this bug should be added.

Comment 8

[:Gijs (he/him)]

(I think we should test-suite this so we don't regress it again)

Comment 9

[Marco Mucci [:MarcoM]]

Added to Iteration 34.1.  Dao, can you mark this bug as either [qa+] or [qa-] for verification.

Comment 10

[Dão Gottwald [:dao]]

Attachment: patch

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Why was this caused by bug 1034845?

Comment 12

[Dão Gottwald [:dao]]

(In reply to :Gavin Sharp [email: [e-mail]] from comment #11)
> Why was this caused by bug 1034845?

Because it replaced the gBrowser.loadURIWithFlags call with openUILinkIn, to avoid duplicating the flags logic.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8465478 [details] [diff] [review]
patch

Review of attachment 8465478 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/utilityOverlay.js
@@ +219,5 @@
>    var aDisallowInheritPrincipal = params.disallowInheritPrincipal;
>    var aInitiatingDoc        = params.initiatingDoc;
>    var aIsPrivate            = params.private;
>    var aSkipTabAnimation     = params.skipTabAnimation;
> +  var aAllowPinnedTabHostChange = !!params.allowPinnedTabHostChange;

Just a heads up that we'll want to add this to the documentation in the header of this function.

Comment 14

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/e3e739ad7b55

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3e739ad7b55

Comment 16

[Andrei Vaida [:avaida]]

I was able to reproduce the initial issue on older Nightlies 33.0a1 (e.g. 2014-07-14, 2014-07-16), as the reporter mentioned in Comment 0 and 2.

Verified fixed on Nightly 34.0a1 (2014-08-03) using Windows 7 64-bit, Mac OS X 10.9.4 and Ubuntu 14.04 LTS 64-bit.

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 8465478 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1034845
[User impact if declined]: see comment 0
[Describe test coverage new/current, TBPL]: https://tbpl.mozilla.org/?rev=e3e739ad7b55
[Risks and why]: trivial fix, low risk
[String/UUID change made/needed]: none

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11f605516d11

Comment 19

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 33.0a2 (2014-08-05) as well, using Windows 7 64-bit, Ubuntu 13.04 32-bit and Mac OS X 10.9.4.

Comment 20

[Mihaela Velimiroviciu (:mihaelav)]

A test for this was landed in bug 1064280