1039923 - media/webrtc/signaling/src/sipcc/include/ccsdp_rtcp_fb.h: [-Wunused-function] 'int32_t sdp_rtcp_fb_nack_to_bitmap(sdp_rtcp_fb_nack_type_e)' defined but not used

Status: RESOLVED WORKSFORME

(Core :: WebRTC, defect)

Description

[Chris Peterson [:cpeterson]]

clang and gcc report the following -Wunused-function warnings on OS X and Android:

> media/webrtc/signaling/src/sipcc/include/ccsdp_rtcp_fb.h:61:1 [-Wunused-function] 'int32_t sdp_rtcp_fb_nack_to_bitmap(sdp_rtcp_fb_nack_type_e)' defined but not used
> media/webrtc/signaling/src/sipcc/include/ccsdp_rtcp_fb.h:73:1 [-Wunused-function] 'int32_t sdp_rtcp_fb_ack_to_bitmap(sdp_rtcp_fb_ack_type_e)' defined but not used
> media/webrtc/signaling/src/sipcc/include/ccsdp_rtcp_fb.h:85:1 [-Wunused-function] 'int32_t sdp_rtcp_fb_ccm_to_bitmap(sdp_rtcp_fb_ccm_type_e)' defined but not used

These -Wunused-function warnings are a little tricky. The functions are defined in a header file as static functions, so functions definitions are emitted in every translation unit that #includes ccsdp_rtcp_fb.h.

The lazy fix is to change these functions from static to inline, except MSVC does not support the `inline` keyword in C code. (MSVC does support `__inline` in C code.)

An alternate fix would be to move the function definitions out of line. However, this header file is #include in both C and C++ files, so the function definitions need to be extern "C".

Comment 1

[:Cykesiopka]

Bug 1091242 removed the relevant functions:
https://hg.mozilla.org/mozilla-central/diff/b6848398dcee/media/webrtc/signaling/src/sdp/sipcc/ccsdp_rtcp_fb.h