103998 - Leaking 1536 bytes from morkArray::AppendSlot when switching newsgroups

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Current trunk, Windows 2000.

Steps to Reproduce:

1.  Have 2 newsgroups set up, I had netscape.public.test and netscape.test.
2.  Switch between them (no need to click on messages).

[W] MLK: Memory leak of 1536 bytes from 1 block allocated in orkinHeap::Alloc
(nsIMdbEnv *,UINT,void * *)
        Distribution of leaked blocks
              1536 bytes from 1 block of 1536 bytes (0x08ff66a0) 
        Allocation location
            new(UINT)+0xc        [C:\WINNT\SYSTEM32\msvcrt.DLL ip=0x580039cb]
            orkinHeap::Alloc(nsIMdbEnv *,UINT,void * *)+0x24 
[c:\moz_src\mozilla\db\mork\src\orkinHeap.cpp:91 ip=0x094164bf]
            morkArray::AppendSlot(morkEnv *,void *)+0x80 
[c:\moz_src\mozilla\db\mork\src\morkArray.cpp:255 ip=0x09449c6d]
            morkTable::AddRow(morkEnv *,morkRow *)+0xda 
[c:\moz_src\mozilla\db\mork\src\morkTable.cpp:644 ip=0x0942cb6b]
            morkBuilder::OnNewRow(morkEnv *,morkPlace const&,morkMid 
const&,BYTE)+0x33c [c:\moz_src\mozilla\db\mork\src\morkBuilder.cpp:542 
ip=0x094377fe]
            morkParser::ReadRow(morkEnv *,int)+0x186 
[c:\moz_src\mozilla\db\mork\src\morkParser.cpp:669 ip=0x09444afa]
            morkParser::ReadTable(morkEnv *)+0x30e 
[c:\moz_src\mozilla\db\mork\src\morkParser.cpp:789 ip=0x09445241]
            morkParser::ReadContent(morkEnv *,BYTE)+0xdd 
[c:\moz_src\mozilla\db\mork\src\morkParser.cpp:1424 ip=0x094470ef]
            ???            [ip=0x09085908]
            morkParser::OnPortState(morkEnv *)+0xa3 
[c:\moz_src\mozilla\db\mork\src\morkParser.cpp:1466 ip=0x094472e0]
            ???            [ip=0x09085908]
            morkParser::ParseLoop(morkEnv *)+0x182 
[c:\moz_src\mozilla\db\mork\src\morkParser.cpp:1522 ip=0x0944768c]
            ???            [ip=0x09085908]
            morkThumb::DoMore(morkEnv *,UINT *,UINT *,BYTE *,BYTE *)+0xb5 
[c:\moz_src\mozilla\db\mork\src\morkThumb.cpp:369 ip=0x09423a24]
            orkinThumb::DoMore(nsIMdbEnv *,UINT *,UINT *,BYTE *,BYTE *)+0xb0 
[c:\moz_src\mozilla\db\mork\src\orkinThumb.cpp:245 ip=0x094245a5]
            nsMsgDatabase::OpenMDB(char const*,int)+0x3ed 
[c:\moz_src\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp:935 ip=0x0dc8bad2]
            nsNewsDatabase::Open(nsIFileSpec *,int,int,nsIMsgDatabase * *)
+0x23b [c:\moz_src\mozilla\mailnews\db\msgdb\src\nsNewsDatabase.cpp:132 
ip=0x0dc87280]
            nsMsgDatabase::OpenFolderDB(nsIMsgFolder *,int,int,nsIMsgDatabase * 
*)+0xe7 [c:\moz_src\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp:859 
ip=0x0dc8b6a7]
            nsMsgNewsFolder::GetDatabase(nsIMsgWindow *)+0x21d 
[c:\moz_src\mozilla\mailnews\news\src\nsNewsFolder.cpp:412 ip=0x094f2409]
            nsMsgDBFolder::GetMsgDatabase(nsIMsgWindow *,nsIMsgDatabase * *)
+0x3f [c:\moz_src\mozilla\mailnews\base\util\nsMsgDBFolder.cpp:641 
ip=0x083ba291]

Comment 1

[David :Bienvenu]

Ok, I think this might be fixed. I can't reproduce it anymore. It might have
been the stuff I checked in the past couple days to cleanup our news db handling.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

I still see this, with the same testcase.  I'll attach output for just this 
stack.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Stack output

Comment 4

[David :Bienvenu]

hmm, I tried with exactly these same newsgroups. I'll try deleting my .msf files
and starting over.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Should I try that, too?

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

BTW, I totally cleaned my whole tree. rm -rf mozilla, then cvs co
mozilla/client.mak from c:\moz_src.  So it's for sure an up-to-date tree.

Comment 7

[David :Bienvenu]

OK, I switched between them twice (selected the first one, the second one, the
first one again, and the second one again) and I didn't see the problem. But if
only select each of them once, I do see the problem (and I start up with the
account central page and not my imap folder - not sure which is key there).

Comment 8

[David :Bienvenu]

plussing.

Comment 9

[David :Bienvenu]

just a data point; this leak still happens even when you read news folders
offline. Still trying to figure out why news would be different from imap or local.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

No mork leaks when switching between newsgroups anymore.

Fixed.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

verified.  I haven't been able to make Mork leak yet since the landing.