Closed Bug 1040048 Opened 9 years ago Closed 9 years ago

Register the OpenH264 plugin from the OpenH264Provider on startup

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 33
Iteration:
34.1

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Add startup registration and test-coverage for registration/unregistration
4.20 KB, patch
benjamin
: review+
Unfocused
: review+
Details | Diff | Splinter Review 
      No description provided.
Flags: firefox-backlog+
Status: NEW → ASSIGNED
Comment on attachment 8458031 [details] [diff] [review]
Add startup registration and test-coverage for registration/unregistration

discussion on IRC, this needs to be attached to profile-after-change or final-ui-startup
Attachment #8458031 - Flags: review-
Comment on attachment 8458031 [details] [diff] [review]
Add startup registration and test-coverage for registration/unregistration

After some testing, it appears that addon providers are loaded early in startup, and so this is ok. I'm going to mark r+ so that we can get this landed and into tomorrow's nightly with everything else, but I'd like Unfocused to do post-facto review to make sure that we're guaranteed that addon providers are always started early.
Attachment #8458031 - Flags: review?(bmcbride)
Attachment #8458031 - Flags: review-
Attachment #8458031 - Flags: review+
Iteration: --- → 33.3
QA Whiteboard: [qa?]
QA would be best in one pass with bug 1009909.
QA Whiteboard: [qa?] → [qa+]
https://hg.mozilla.org/mozilla-central/rev/ad53b74f0bf2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Hi Florin, can a QA contact be assigned for verification of this bug.
Flags: needinfo?(florin.mezei)
Comment on attachment 8458031 [details] [diff] [review]
Add startup registration and test-coverage for registration/unregistration

Review of attachment 8458031 [details] [diff] [review]:
-----------------------------------------------------------------

Read the backscroll on IRC - yes, currently providers are always loaded on startup.
Attachment #8458031 - Flags: review?(bmcbride) → review+
Flags: needinfo?(florin.mezei)
QA Contact: alexandra.lucinet
Iteration: 33.3 → 34.1
Hi Alexandra, following up to see if this bug can be verified by the end of the iteration on Monday August 4.
Flags: needinfo?(alexandra.lucinet)
Verified as fixed with latest Aurora (buildID: 20140731004002) on Ubuntu 13.04 64bit, Mac OS X 10.9.4 and Windows 7 x64 - after restarting the browser, a h264 call is successfully made.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Flags: needinfo?(alexandra.lucinet)
You need to log in before you can comment on or make changes to this bug.