[v2.1][v2.0] Intermittent test_settings_do_not_track.py failure

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: AndreiH, Assigned: AndreiH)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

4 years ago
http://jenkins1.qa.scl3.mozilla.com/job/flame.mozilla-aurora.ui.functional.non-smoke/5/HTML_Report/


Traceback (most recent call last):
  File "/home/andreihutusoru/.virtualenvs/b2g-gaia/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 170, in run
    testMethod()
  File "/home/andreihutusoru/webQA/b2g-gaia/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_do_not_track.py", line 31, in test_enable_do_not_track_via_settings_app
    self.assertEqual(self.data_layer.get_bool_pref('privacy.donottrackheader.enabled'), True)
TEST-UNEXPECTED-FAIL | test_settings_do_not_track.py test_settings_do_not_track.TestSettingsDoNotTrack.test_enable_do_not_track_via_settings_app | AssertionError: False != True
(Assignee)

Updated

4 years ago
Priority: -- → P1
(Assignee)

Comment 1

4 years ago
I remember seeing this on v2.1 too
Summary: [v2.0] Intermittent test_settings_do_not_track.py failure → [v2.1][v2.0] Intermittent test_settings_do_not_track.py failure
(Assignee)

Updated

4 years ago
Assignee: nobody → andrei.hutusoru
(Assignee)

Comment 2

4 years ago
started adhock:

v2.0: http://jenkins1.qa.scl3.mozilla.com/view/Flame/job/flame.mozilla-aurora.ui.adhoc/1/console

master: http://jenkins1.qa.scl3.mozilla.com/view/Flame/job/flame.mozilla-central.ui.adhoc/3/console
(Assignee)

Comment 3

4 years ago
Created attachment 8458494 [details] [review]
Master PR

I don't know if you agree withe this changes, but it makes more sense to me.
Attachment #8458494 - Flags: review?(zcampbell)
Attachment #8458494 - Flags: review?(robert.chira)
Attachment #8458494 - Flags: review?(florin.strugariu)

Comment 4

4 years ago
AndreiH, it failed in the Aurora adhoc, are you sure this change is doing anything?

Comment 5

4 years ago
Comment on attachment 8458494 [details] [review]
Master PR

r- because the adhoc failed.
I suspect it's not actually tapping on the radio button properly, Intermittents are often the step before the one that's failing.
Attachment #8458494 - Flags: review?(zcampbell) → review-
(Assignee)

Comment 6

4 years ago
Comment on attachment 8458494 [details] [review]
Master PR

Zac the adhoc is before the patch :) sorry I didn't specify that.
Attachment #8458494 - Flags: review- → review?(zcampbell)
(Assignee)

Comment 7

4 years ago
Adhoc with the patch:
http://jenkins1.qa.scl3.mozilla.com/view/Flame/job/flame.mozilla-central.ui.adhoc/4/console
(Assignee)

Comment 8

4 years ago
The test failed again on v2.0:
http://jenkins1.qa.scl3.mozilla.com/view/Flame/job/flame.mozilla-aurora.ui.functional.non-smoke/7/HTML_Report/
Comment on attachment 8458494 [details] [review]
Master PR

see comment in the pull

I think adding those waits in the tests reduces the readability and we should wait for the changes in the app object
Attachment #8458494 - Flags: review?(florin.strugariu) → review-

Comment 10

3 years ago
Comment on attachment 8458494 [details] [review]
Master PR

r- because the test failed again on adhoc. Moving the waits must not fix the problem, it must be something else, possibly the tap before the way not actually executing.
Attachment #8458494 - Flags: review?(zcampbell)
Attachment #8458494 - Flags: review?(robert.chira)
Attachment #8458494 - Flags: review-
Created attachment 8468456 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/22571
Attachment #8458494 - Attachment is obsolete: true
Attachment #8468456 - Flags: review?(zcampbell)
Attachment #8468456 - Flags: review?(robert.chira)
Comment on attachment 8468456 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/22571

You should make the pull for master and then uplift
Attachment #8468456 - Flags: review?(robert.chira) → review-
Created attachment 8469304 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/22629

I opened a PR on master and also started an adhoc run: http://jenkins1.qa.scl3.mozilla.com/job/flame.mozilla-central.ui.adhoc/91/console
Attachment #8468456 - Attachment is obsolete: true
Attachment #8468456 - Flags: review?(zcampbell)
Attachment #8469304 - Flags: review?(zcampbell)
Attachment #8469304 - Flags: review?(robert.chira)
Attachment #8469304 - Flags: review?(robert.chira) → review+
https://github.com/mozilla-b2g/gaia/commit/dea4b90ca5e72625f7f7f27157709faba060bcd2
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Attachment #8469304 - Flags: review?(zcampbell)
Created attachment 8470681 [details] [review]
PR for v2.0: https://github.com/mozilla-b2g/gaia/pull/22717
Attachment #8470681 - Flags: review?(robert.chira)
Attachment #8470681 - Flags: review?(robert.chira) → review+
v2.0 commit https://github.com/mozilla-b2g/gaia/commit/edaefce424b78505a82a79cc7a2b5eef9b5e53d3
You need to log in before you can comment on or make changes to this bug.