1040204 - Loop - implement a "loop-call" activity that accepts URL tokens.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

We already have an activity that accepts a webcontact object to initiate a Loop user to Loop user call. Now we need another activity that accepts an URL token so we can start an anonymous user to Loop user call.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/49

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8460246 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/49

LGTM. r=me

Left a few nits on the PR. Please rebase this before landing in order to add the bumping up version mechanism.

On the other hand I've not tested this patch as we need -mostly- the standalone client bits from bug 1008990. IMHO you could land this as it is right now and file a follow-up bug (if needed) to fine-tune what you need in the FxOS Loop client.

Thanks Fernando!

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 8460246 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/49

Some issues to fix. Let me know when ready and I'll review the final patch! Please remove the commit related with the Contacts Cache, as this code is not tied to that functionality. Thanks!

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

I've rebased the PR on top of master and uploaded a test app to https://github.com/ferjm/loop-call-activity-test

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Test application

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/6a334fa52048afb12d4a3be7be39061d29f2aa6c