Closed Bug 1040204 Opened 10 years ago Closed 10 years ago

Loop - implement a "loop-call" activity that accepts URL tokens.

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(2 files)

We already have an activity that accepts a webcontact object to initiate a Loop user to Loop user call. Now we need another activity that accepts an URL token so we can start an anonymous user to Loop user call.
Component: Client → Gaia::Loop
Product: Loop → Firefox OS
Assignee: nobody → ferjmoreno
Blocks: Loopmov_1_1
Comment on attachment 8460246 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/49

LGTM. r=me

Left a few nits on the PR. Please rebase this before landing in order to add the bumping up version mechanism.

On the other hand I've not tested this patch as we need -mostly- the standalone client bits from bug 1008990. IMHO you could land this as it is right now and file a follow-up bug (if needed) to fine-tune what you need in the FxOS Loop client.

Thanks Fernando!
Attachment #8460246 - Flags: review?(josea.olivera) → review+
Comment on attachment 8460246 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/49

Some issues to fix. Let me know when ready and I'll review the final patch! Please remove the commit related with the Contacts Cache, as this code is not tied to that functionality. Thanks!
Attachment #8460246 - Flags: feedback+
Attachment #8460246 - Flags: review?(borja.bugzilla)
Attachment #8460246 - Flags: review?(borja.bugzilla)
I've rebased the PR on top of master and uploaded a test app to https://github.com/ferjm/loop-call-activity-test
Attached file Test application
Attachment #8460246 - Flags: review?(borja.bugzilla) → review+
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/6a334fa52048afb12d4a3be7be39061d29f2aa6c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: