104021 - Profile mgr needs to put necko offline when switching profile

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Conrad Carlen (not reading bugmail)]

This came from bug 101329 - summary says it all.

We need to put necko offline and then wait until receiving notification that it
really is offline before proceding with shutting down the profile. For that, see
bug 104020.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch 1

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 56684 [details] [diff] [review]
patch 1

how about just renumbering the Phases?  :-)

Comment 3

[Darin Fisher]

Comment on attachment 56684 [details] [diff] [review]
patch 1

rs=darin

Comment 4

[Conrad Carlen (not reading bugmail)]

Kai - drivers have requested another review for this to go into 0.9.6. Can you
do it? Between this and bug 104020, all net activity should now be stopped when
the NSSComponent gets the profile-before-change notification.

Comment 5

[Kai Engert (:KaiE:)]

You are only adding a new notification, that is currently not used anywhere.

But the code is required for the fix that I will produce for bug 104020.

You notification is currently not used and therefore can't cause any trouble for
096.

r=kaie

Comment 6

[Conrad Carlen (not reading bugmail)]

Kai, I'm not sure what you mean. This notification will be used by the code
which was checked in for bug 104020. That patch is in place and the bug is closed.

Comment 7

[Kai Engert (:KaiE:)]

I should have updated my tree before using grep to search it for the new
notification string you added...

Ok, your patch will already trigger necko to go off or back online. That's what
we want and your patch looks good.

r=kaie

Comment 8

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.6

Comment 9

[Kai Engert (:KaiE:)]

I'm marking this fixed, as the code seems to have landed on the trunk.

Comment 10

[Conrad Carlen (not reading bugmail)]

Removing blockage of 104864 because this is in 0.9.6. It was checked in before
the branch was cut.

Comment 11

[Christopher Blizzard (:blizzard)]

Re-adding the 0.9.6 tracking bug since we need to keep track of all of the 0.9.6
bugs that were labeled as such. ( This is closed - it's OK. )

Comment 12

[K'Trina Medina]

Verified code fix