Write testcases for XBL/Shadow trees using display-box:contents

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mats, Assigned: wchen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Reporter

Description

5 years ago
See also bug 1040283 that covers documenting the various cases.
It would be great to have tests to cover those cases and in
particular tests that fail with the current patches in bug 907396.

Bug 907396 adds a large number of tests for normal content
under layout/reftests/css-display/ so that's probably the
best place to add new tests.
Assignee

Comment 1

5 years ago
These test cases fail with display-box:contents
Reporter

Comment 2

5 years ago
Thanks for the tests William - I'll take a look...
Reporter

Comment 3

5 years ago
Posted patch patchSplinter Review
I think I have this working now, both for XBL and shadow DOM.
Try builds if you want to test something:
https://tbpl.mozilla.org/?tree=Try&rev=01f2dc6fc43f
(nevermind the devtools orange - it's expected)

I've extended and added to your tests, and also added a bunch of
shadow DOM tests, for the various edge cases I could think of:
layout/reftests/css-display/display-contents-xbl.xhtml
layout/reftests/css-display/shadow-display-contents-1.html

Let me know if you see something is wrong or missing.
Reporter

Comment 4

5 years ago
I've added tests for XBL and shadow DOM trees in bug 907396 now.
Thanks for your help.
Assignee: nobody → wchen
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.