Closed Bug 1040291 Opened 10 years ago Closed 10 years ago

Write testcases for XBL/Shadow trees using display-box:contents

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: MatsPalmgren_bugz, Assigned: wchen)

References

Details

Attachments

(2 files)

See also bug 1040283 that covers documenting the various cases.
It would be great to have tests to cover those cases and in
particular tests that fail with the current patches in bug 907396.

Bug 907396 adds a large number of tests for normal content
under layout/reftests/css-display/ so that's probably the
best place to add new tests.
These test cases fail with display-box:contents
Thanks for the tests William - I'll take a look...
Attached patch patchSplinter Review
I think I have this working now, both for XBL and shadow DOM.
Try builds if you want to test something:
https://tbpl.mozilla.org/?tree=Try&rev=01f2dc6fc43f
(nevermind the devtools orange - it's expected)

I've extended and added to your tests, and also added a bunch of
shadow DOM tests, for the various edge cases I could think of:
layout/reftests/css-display/display-contents-xbl.xhtml
layout/reftests/css-display/shadow-display-contents-1.html

Let me know if you see something is wrong or missing.
I've added tests for XBL and shadow DOM trees in bug 907396 now.
Thanks for your help.
Assignee: nobody → wchen
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: