1040442 - [Lint] contacts_account_chooser_dialog_title should use ellipsis, not three periods

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Replace "..." with ellipsis character (…, …) ?

Issue: Looks for ellipsis strings (...) which can be replaced with an ellipsis character
Id: TypographyEllipsis

You can replace the string "..." with a dedicated ellipsis character, ellipsis character (…, …). This can help make the text more readable.

[http://en.wikipedia.org/wiki/Ellipsis]


  <!-- Contacts API -->
  <string name="contacts_account_chooser_dialog_title">Share contacts from...</string>


This has already been localized. Don't forget to rename the string and add a localization note.

Comment 1

[Richard Newman [:rnewman]]

Attachment: [Lint] contacts_account_chooser_dialog_title should use ellipsis, not three periods. v1

Not yet localized, actually -- that's an artifact of the build, as best I can tell. But still good practice to rev those names when contents change.

Comment 2

[Shane Tully (:stully:]

Comment on attachment 8458407 [details] [diff] [review]
[Lint] contacts_account_chooser_dialog_title should use ellipsis, not three periods. v1

Review of attachment 8458407 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure I'm qualified to r+ this since this was from my internship last summer and I haven't worked on anything Mozilla related since then, but sure, looks good to me!

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/d7b557fac82c

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8458407 [details] [diff] [review]
[Lint] contacts_account_chooser_dialog_title should use ellipsis, not three periods. v1

I might be mistaken, but I'm not sure strings directly added to strings.xml.in are actually part of the l10n process. I mention that because we typcially do not bump entities in strings.xml.in since l10n translators never see them. They only see the changes in the locales folder.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #4)

> I might be mistaken, but I'm not sure strings directly added to
> strings.xml.in are actually part of the l10n process.

Correct; see Comment 1. Bumping the number is just a good habit.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d7b557fac82c