1040548 - Move state (input sequence) out of IME engines and clean up the IME Engine API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #1038131 +++

This originated from bug 1038131 comment 10, that we should have a proper fix for bug 1015541.
 1. Should not have input sequence in latin IME, the state should be moved to keyboard module itself or have a separate "inputConnection" module.

 2. Should refine the IME APIs.

--
This may evolve into a meta bug, would try to do this with some small steps and get some integration tests ready first.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I really don't like this bug becoming a meta bug again -- we don't really need that much tracking bugs. But still I filed bug 1040603 to specify the first steps to do.

I don't think we could change a lot of IME API detail in neither of these two bugs. Let's do that else where.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug1040548-remove_input_sequence > mozilla-b2g:master

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8595313 [details] [review]
[gaia] RudyLu:keyboard/Bug1040548-remove_input_sequence > mozilla-b2g:master

I think this is ready for review.

Tim, could you please help?
Thank you.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8595313 [details] [review]
[gaia] RudyLu:keyboard/Bug1040548-remove_input_sequence > mozilla-b2g:master

Nice work. Please make sure the performance does not regress.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/4d87112bbf48cdd09c19e553cc9aebd2a2c4ddfd