1040566 - [UICC][STK] GET_INKEY, GET_INPUT timeout duration doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Youngjun Kim]

- User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Trident/6.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.3; .NET4.0C; CNS_UA; AD_LOGON=4C47452E4E4554)

- Steps to reproduce:
Process SimToolkit Command (GET_INKEY, GET_INPUT).

- Actual results:
time duration is not working.

- When processing GET_INKEY, GET_INPUT command, time duration didn't set normally. I think time duration value have to set below. (icc_work.js, icc.js)
Please check source icc_worker.js, icc.js

1. icc_worker.js

[Before]
var timeout = (options.duration &&
      icc.calculateDurationInMS(options.duration)) || icc._inputTimeout;

[After]
    var timeout = (options.duration &&
      icc.calculateDurationInMS(options.duration.timeUnit,
          options.duration.timeInterval)) || icc._inputTimeout;

==========================================================================

icc.js
[Before]
 calculateDurationInMS: function icc_calculateDurationInMS(timeUnit,
    timeInterval) {
    var timeout = timeInterval;
    switch (timeUnit) {
      case this._iccManager.STK_TIME_UNIT_MINUTE:
        timeout *= 360000;
        break;

[After]
      case this._iccManager.STK_TIME_UNIT_MINUTE:
        timeout *= 60000;

Comment 1

[Youngjun Kim]

Please review the patch.

Comment 2

[promise09th]

Attachment: Bug_1040566_patch.html

Comment 3

[Wayne Chang [:wchang]]

ni?frsela

Fernando, do you still review STK code?

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8458516 [details]
Bug_1040566_patch.html

Thank you !

Comment 5

[Wayne Chang [:wchang]]

Nominating this for 2.0 as partner needs this fixed on their product. According to comment 0 it's a trivial bug that needs fixing, without the fix it might impact STK cert testing.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/5c272dee2f0b5ded811626bbd8f951a50fbcbe64
v2.0: https://github.com/mozilla-b2g/gaia/commit/91987e8bc729f7a5cd39a39f4c891ec8e8d5606f

Comment 9

[Adam Alldredge [:AdamA][Inactive]]

Unable to verify this issue because it is a backend issue.