1040708 - Use the preset workloads defined in b2gpopulate

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Bug 1040705 will introduce preset workload quantities, which we should use in Eideticker instead of hard-coded values.

Comment 1

[William Lachance (:wlach)]

Hey Gautam, this would be a nice quick one to try doing after you've finished up with bug 1040705

Comment 2

[Gautam Akiwate [:gakiwate]]

(In reply to William Lachance (:wlach) from comment #1)
> Hey Gautam, this would be a nice quick one to try doing after you've
> finished up with bug 1040705

Can you post a quick summary as to what needs to be done exactly?

Comment 3

[William Lachance (:wlach)]

Hey Gautam, pretty simple. We need to replace "magic" numbers we're passing to b2gpopulate with ones that you're adding to b2gpopulate. Here's an example:

https://github.com/mozilla/eideticker/blob/master/src/eideticker/eideticker/b2gtestmixins.py#L19

We should replace this with the values that you're putting into bug 1040705. Do "git grep device.b2gpopulate" to find the other instances. I think in most cases they should be from the light workload?

Comment 4

[Gautam Akiwate [:gakiwate]]

Sounds good. Will do this once, davehunt gives a go ahead on the earlier patch.

Comment 5

[Gautam Akiwate [:gakiwate]]

Attachment: Bug-1040708-Use-the-preset-workloads-defined-in-b2gp.patch

gakiwate@ubuntu:~/Projects/eideticker$ grep -r "self.device.b2g" .
./src/eideticker/eideticker/b2gtestmixins.py:        self.device.b2gpopulate.populate_contacts(
./src/eideticker/eideticker/b2gtestmixins.py:        self.device.b2gpopulate.populate_messages(200, restart=False)
./src/tests/b2g/launching/gallery.py:        self.device.b2gpopulate.populate_pictures(self.picture_count)
./src/tests/b2g/launching/music.py:        self.device.b2gpopulate.populate_music(
./src/tests/b2g/scrolling/callog.py:        self.device.b2gpopulate.populate_calls(100, restart=False)

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8462240 [details] [diff] [review]
Bug-1040708-Use-the-preset-workloads-defined-in-b2gp.patch

Review of attachment 8462240 [details] [diff] [review]:
-----------------------------------------------------------------

r- due to the change in values. If we want to standardise on the light workload, we should make sure we notify the perf team and anybody consuming the results as these are likely to be affected.

::: src/tests/b2g/launching/gallery.py
@@ +9,4 @@
>  
>  
>  class Test(B2GAppStartupTest):
> +    picture_count = self.device.b2gpopulate.WORKLOADS['light']['picture']

100 pictures is actually the 'heavy' workload.

::: src/tests/b2g/launching/music.py
@@ +11,4 @@
>  class Test(B2GAppStartupTest):
>  
>      def prepare_app(self):
> +        music_count = self.device.b2gpopulate.WORKLOADS['light']['music']

100 tracks is the 'heavy' workload.

::: src/tests/b2g/scrolling/callog.py
@@ +12,5 @@
>          self.scrolldown_amount = int(testinfo.get('scrolldown_amount'))
>  
>      def populate_databases(self):
> +        self.device.b2gpopulate.populate_calls(
> +            self.device.b2gpopulate.WORKLOADS['light']['call'], restart=False)

100 calls is the 'medium' workload.

Comment 7

[Gautam Akiwate [:gakiwate]]

Another issue, I just realized is that the WORKLOAD isn't part of the B2GPopulate class. So, self.device.b2gpopulate.WORKLOADS won't work anyway.

One solution could be to a add a 'getter' function in the class that gets a specific value based on the workload and the type. Alternatively, WORKLOADS can be brought into the class but it seems it might require a lot of restructuring in the other classes that use WORKLOADS.

What would be the better way forward?

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Locally this works for me if I add from `b2gpopulate import WORKLOADS` to b2gpopulate/__init__.py

Comment 9

[Gautam Akiwate [:gakiwate]]

Attachment: Bug-1040708-Use-the-preset-workloads-defined-in-b2gp.patch

Updated the values.

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8465698 [details] [diff] [review]
Bug-1040708-Use-the-preset-workloads-defined-in-b2gp.patch

Review of attachment 8465698 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though we will have to make the change to b2gpopulate's __init__.py as outlined by Dave in comment 8 (and release a new version of b2gpopulate) before landing this.

Comment 11

[Gautam Akiwate [:gakiwate]]

I have initiated a pull request for Dave with the changes listed in comment 8.
https://github.com/mozilla/b2gpopulate/pull/26

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Gautam Akiwate [:gakiwate] from comment #11)
> I have initiated a pull request for Dave with the changes listed in comment 8.
> https://github.com/mozilla/b2gpopulate/pull/26

Landed in:
https://github.com/mozilla/b2gpopulate/commit/a109ea16b84c797f9f13c58cbddc6e621a3da150

Version bumped in:
https://github.com/mozilla/b2gpopulate/commit/05fa676821c4146d3c40816ee12298ef6ead8205

Released as:
https://pypi.python.org/pypi/b2gpopulate/0.27

Tagged as:
https://github.com/mozilla/b2gpopulate/releases/tag/0.27

Comment 13

[William Lachance (:wlach)]

Pushed, thanks! https://github.com/mozilla/eideticker/commit/254fa7277ef98325318a33932a1bdf59007143d2

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Uplifted b2gpopulate change to expose WORKFLOW to v2.0:
https://github.com/mozilla/b2gpopulate/commit/94c6812aa91e632988c46f3ed9e57d11413c03fc

Version bumped in:
https://github.com/mozilla/b2gpopulate/commit/e2aee48ce2cbfa82ee138d176c829d733a3eb3f0

Released as:
https://pypi.python.org/pypi/b2gpopulate-v2.0/0.2

Tagged as:
https://github.com/mozilla/b2gpopulate/releases/tag/v2.0-0.2