1040823 - OdinMonkey: make --js-cache-per-process the default for tests running on TBPL

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

This will allow us to have more tests for caching, and existing tests could be enhanced as well (for instance, probably because of that, testCaching.js doesn't check that the module hasn't been loaded from the cache, for the first compilation).

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Patch

This patches makes cache per process the default and introduces a --no-js-cache-per-process, such that we can still use asmCompileCached and testBullet.

Try run without any other patches applied:
https://tbpl.mozilla.org/?tree=Try&rev=79a8bd58083f

This try run has the original patches from bug 986673 applied, to ensure that it really solves the issue:
https://tbpl.mozilla.org/?tree=Try&rev=80e8eaebc2e2

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Try builds are so green! I also pushed the test modifications from bug 986673 (no r?, tests only).

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b1f90479edd6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a501189a5364

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b1f90479edd6
https://hg.mozilla.org/mozilla-central/rev/a501189a5364