Closed Bug 1040823 Opened 7 years ago Closed 6 years ago

OdinMonkey: make --js-cache-per-process the default for tests running on TBPL

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

Attachments

(1 file)

This will allow us to have more tests for caching, and existing tests could be enhanced as well (for instance, probably because of that, testCaching.js doesn't check that the module hasn't been loaded from the cache, for the first compilation).
Attached patch PatchSplinter Review
This patches makes cache per process the default and introduces a --no-js-cache-per-process, such that we can still use asmCompileCached and testBullet.

Try run without any other patches applied:
https://tbpl.mozilla.org/?tree=Try&rev=79a8bd58083f

This try run has the original patches from bug 986673 applied, to ensure that it really solves the issue:
https://tbpl.mozilla.org/?tree=Try&rev=80e8eaebc2e2
Assignee: nobody → benj
Status: NEW → ASSIGNED
Attachment #8458754 - Flags: review?(luke)
Attachment #8458754 - Flags: review?(luke) → review+
Try builds are so green! I also pushed the test modifications from bug 986673 (no r?, tests only).

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b1f90479edd6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a501189a5364
https://hg.mozilla.org/mozilla-central/rev/b1f90479edd6
https://hg.mozilla.org/mozilla-central/rev/a501189a5364
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.