1040827 - System app keeps splash icons alive

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Benoit Girard (:BenWa)]

+++ This bug was initially created as a clone of Bug #1040341 +++

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #3)
> App Icons appears in the background of an application, when it is launched.
> We can probably removed them once the app is loaded.

I can confirm this. They are set in AppWindow.prototype.setFrameBackground.

This bug should be about removing this icon once the app is launched. After you have a few apps started I see a MB or two used up by these icons. The system app, unlike the rest of b2g, keeps these images around much more aggressively so we need to be more diligent about removing them.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch

This patch removes the image but I don't know the code enough to know if there's unwanted side effects. Can someone take this up and get it landed?

Comment 2

[Gregor Wagner [:gwagner]]

(In reply to Benoit Girard (:BenWa) from comment #1)
> Created attachment 8458776 [details] [diff] [review]
> patch
> 
> This patch removes the image but I don't know the code enough to know if
> there's unwanted side effects. Can someone take this up and get it landed?

Alive, what do you think?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Sorry, but I cannot :(
The icon is still necessary when doing swipe navigation;
we should display the icon + name of the background app when we swipes.

What we could do might be: drop the icon after mozbrowserloaded and re-render it on demand.
Etienne how do you think?

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Alive Kuo [:alive][NEEDINFO!][PTO until 9/9] from comment #3)
> Sorry, but I cannot :(
> The icon is still necessary when doing swipe navigation;
> we should display the icon + name of the background app when we swipes.
> 
> What we could do might be: drop the icon after mozbrowserloaded and
> re-render it on demand.
> Etienne how do you think?

We could try, and figure out if it doesn't break the fast edge swipes to go through multiple apps.
Benoit, do we need to remove the style.backgroundImage? Or can we just hide the identificationIcon? The container (.identification-overlay) is already be visibility:hidden. Should we use a real image tag?

Comment 5

[Benoit Girard (:BenWa)]

I believe if the style is removed from the DOM then the image should be discarded.

Comment 6

[Eric Rahm [:erahm]]

Closing out old Firefox OS specific memshrink bugs.