1040906 - To3DMatrix and ToMatrix4x4 should have return values instead of out-parameters

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The matrix conversion routines take out-parameters which I find extremely annoying because it requires creating a local variable at the call site when sometimes you wouldn't need one otherwise (e.g. if you're just passing the converted result to a function right away).

Instead of doing this:

gfx3DMatrix tmp;
To3DMatrix(aLayer->GetTransform(), tmp);
myRegion.Transform(tmp);

you should just be able to do this:

myRegion.Transform(To3DMatrix(aLayer->GetTransform()));

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Bas, since you added the code, do you have any objections to this change? It should all get inlined anyway so I don't think there would be any perf impact. If you have no objections I'm happy to be a mentor for it (or implement it if it annoys me sufficiently).

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

It annoyed me sufficiently.

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8458985 [details] [diff] [review]
Patch

Review of attachment 8458985 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think I actually wrote this code! :) But looks good to me!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

That's what the blame said. Ah well.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a2c46ad0b5

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Follow-up because I missed a call site in gonk:

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd44af6a0e8d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e6a2c46ad0b5
https://hg.mozilla.org/mozilla-central/rev/bd44af6a0e8d