104091 - MAPI: Sending unsaved WordPad doc give error message

Status: VERIFIED FIXED

(MailNews Core :: Simple MAPI, defect, P3)

Description

[Antonio Lam]

Build Used: 2001-10-09-10.0.9.4

When sending an unsaved WordPad document via MAPI, the following error message 
pop up:

"an unnamed file was not found" (Screenshot will be follow.)

before the mail compose window show up. 

In the compose window, the document is attached, but the subject line is left 
blank (used to be "document.doc")

Note:  It worked fine if sending via Outlook Express or Netscape Messenger (no 
error message pop up).

Comment 1

[Antonio Lam]

Attachment: Error message dialog from WordPad

Comment 2

[lchiang]

nominating.  Not a good thing to show.

Does not appear to happen for MS Word.  Only seen in Wordpad so far, I think.

Comment 3

[Tiantian Kong]

Reassign to Rajiv.

Comment 4

[Jaime Rodriguez, Jr.]

Pls verify that the document was recieved after it is sent.

Comment 5

[Jaime Rodriguez, Jr.]

Is the same dialogue box showing up for Outlook Explorer as the MAPI client.

How about, is you save the document, and make modifications, which version of
the document will you be sending?

Comment 6

[Antonio Lam]

The unsaved WordPad document was recieved by the recipient after it is sent.

Comment 7

[Jaime Rodriguez, Jr.]

For relnote, make sure to tell people to save files before sending = PDT-

Comment 8

[Rajiv Dayal]

Well this is happening because when one sends an unsaved file from Wordpad it
(this is also done by Word, Excel, Powerpoint) creates a temporary file in the
system's temp dir and then passes that temp file name as the file to send. What
we do in send is move this file to a MozMapi temp dir (within the system's temp
dir) and replace the name with the real filename. We delete the temp file after
send is done. Since we move the file, this temp file is not there and when
Wordpad tries to delete the temp file it fails. The MS Office apps donot display
any error if this temp file is not found during deletion whereas Wordpad does.

We wrote the code to move rather than copy since it is much better from
performance as well as disk usage point of view, specially if the file to be
sent is large. Also the MS Office apps donot mind that (no error msg).

The fix for this is very simple (copy the file instead of move) but we need to
decide if it is OK from the performance point of view.

Comment 9

[Rajiv Dayal]

The patch in bug # 102645 also solves this problem.

Comment 10

[Tiantian Kong]

Attachment: fix for FrontPage crash and WordPad msg after send, copied from 102654

Comment 11

[Tiantian Kong]

Comment on attachment 53787 [details] [diff] [review]
fix for FrontPage crash and WordPad msg after send, copied from 102654

has r = ducarroz,
sr = mscott.
r and sr given on bug # 102645.

Checked in yesterday (10/15) into 094 branch.

Comment 12

[Tiantian Kong]

Trix can u please verify Send in both FrontPage and Wordpad with today's build.

Comment 13

[Tiantian Kong]

The patch for this bug was originally posted in bug 102645, since the comments
for Frontpage is in that bug. Copied below for future reference.


------ Additional Comments From [e-mail] 2001-10-12 12:25 -------

I think I have a consistently reproducible case for a crash..but it is in 
MS Frontpage 2000 (v 4.0.2.2717)
Every time I send to our mail via mapi with a html file created in Frontpage, I
can successfully send the file thru our mapi, but it will (within Frontpage)
report in a dialog  "An unmamed file was not found". When I click OK to the
dialog, after a few seconds more, Frontpage will crash with the error I attached
earlier. Other apps such as Word and  Powerpoint  don't give this crash or
dialog. (I am on a Win 2k box)
This happens every time for me.



------- Additional Comments From Rajiv Dayal 2001-10-12 17:37 -------

I have the solution for the Front Page crash. This is happening for the similiar
reason why WordPad is displaying the error message when sending unsaved document
(bug # 104091).

MS Office apps and WordPad creates a temp file for unsaved documents and send
the path name for this temp file as well as the real file name for it to
MAPISend. However, FrontPage decides to do this even for saved docuemnts !! 

Now all these apps try to delete the temp file they created and behave
differently when they do so. MS Office apps donot display any error messages
when they donot find this temp file created for the sole purpose of the
messaging app, WordPad displays an error message whereas FrontPage decides that
it is very severe and crashes.

As I mentioned in bug # 104091 there is a simple fix, rather than us moving the
temp file to our moz_mapi temp dir (which we did for performance reason in case
of large files) and rename with real filename we make a copy of this temp file
with real filename in our moz_mapi temp dir.

Please find the fix in the patch below.

Comment 14

[Trix Supremo]

verified on 2001-10-16-05-0.9.4 that the error message is no longer displayed on
send and the send is successful with the attachments being readable.

but, in regards to the first description that the file name should be in the
subject line, communicator 4.x does display the attached filename on the subject
line, but Outlook Express does not.  

Since similar feature sets with Communicator 4.x has been the one of the goals
and this a different issue, i'll file another bug regarding this.

Comment 15

[scalkins]

 Frontpage 2k no longer crashes with todays build when sending via mapi. No
error dialogs before the crash either. This was a consistent crash and error
dialog  for me earlier.
verifying Win 32 2001-10-16-05 0.9.4 Branch