104094 - dragging url icon to Set Home Page results in blank/messed up dialog

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[sairuh (rarely reading bugmail)]

thx to Asa for pointing this out. so far, i've only seen this on Mac 9.x, both
in classic environment over 10.1, and in native 9.1.

pink, not sure you're the right person, so punt as needed. dunno if this is
failure in d'n'd, toolbar stuff or bookmarking or the url bar...

tested using 2001.10.10.03-0.9.4 comm trunk bits. seems to occur with both new
and older profiles, in either modern or classic themes.

1. load a page whose url differs from your currently set home page. eg, my
current home page is http://home.netscape.com --i then load http://mozilla.org
2. drag the protocol icon of the url in the URL bar onto the Home icon in the
personal toolbar.

actual results:
i've seen several things occur, but i think they might stem from the same issue
[but correct me if they aren't]:

a. after waiting 30sec-1min, the "Set Home Page" dialog finally appears...except
that it's blank [except for the titlebar]. it remains blank, too --i got
impatient after 10min passed. i am able to dismiss it by hitting the Esc key,
though.

b. after waiting 1-3min, the "Set Home Page" dialog finally appears --it's not
blank, and the buttons are responsive --seems to work, at least when i click Cancel.

c. after waiting 1-3min, "Set Home Page" finally appears. it's not blank, and
the buttons seem to respond...but when i clicked one [Cancel], i crashed.

d. after waiting 1-3min, "Set Home Page" finally appears. again, not blank, but
this time the buttons are completely non-responsive to mouse-clicks.

i've seen a-c when running 9.1 under 10.1 [classic env]. Asa has seen at least
[d]. Asa, were you running 9.x natively? did hitting Esc or Return do anything?
what other related behaviors have you seen here?

Comment 1

[sairuh (rarely reading bugmail)]

notes about the cases above:

[a] occurred the first time i launched a new profile.

[b] occurred in the same profile as [a], but it was the first attempt in a
later/different browser session.

[c] the crash [which the trace below is from] occurred when i tried dragging the
protocol icon a second time during the same session as [b].

dunno if i was clear above, but [a]-[c] occurred using 2001.10.10.03-0.9.4
commercial *branch* bits.

Incident ID 36526421
Stack Signature DragLib + 0x9068 (0x3994d488) 360a4cb9
Trigger Time 2001-10-10 13:26:53

Build ID 2001101003
Product ID Netscape6.20
Platform ID MacOS
Trigger Reason PowerPC unmapped memory exception
Stack Trace
DragLib + 0x9068 (0x3994d488)
DragLib + 0x1498 (0x399458b8)
DragLib + 0x18fc (0x39945d1c)
DragLib + 0xb3ac (0x3994f7cc)
nsDragService::InvokeDragSession() [nsDragService.cpp, line 258]
CODE.10
XPTC_InvokeByIndex() [xptcinvoke_mac.cpp, line 129]
XPCWrappedNative::CallMethod() [xpcwrappednative.cpp, line 1951]
XPC_WN_CallMethod() [xpcwrappednativejsops.cpp, line 1262]
js_Invoke() [jsinterp.c, line 801] 

Comment 2

[sairuh (rarely reading bugmail)]

btw, i don't think this is a problem on linux or win32...or even os x, iirc.

Asa, have you been seeing this on the trunk?

i'm testing this on 9.1, native os, not under 10.1 classic emulation, using
2001.10.10.03-0.9.4 bits still.

1. first time during a session i attempt this, "Set Home Page" comes up
immediately. i'm able to click Cancel and dismiss it.
2. the second time i try, "Set Home Page" comes up blank. after waiting about
3min with no change, i hit Esc and Return to dismiss it...but no response.
forced to quit using Macsbug.

should this be nominated for the branch and/or 0.9.5? if not, feel free to
remove the kw's...

Comment 3

[Simon Fraser [no longer active]]

This may be because we're trying to do too much from within the drag manager 
callbacks. We should post an event, and handle stuff outside of the callback.

Comment 4

[Mike Pinkerton (not reading bugmail)]

trying to show a modal dialog from the JS executed by a drag handler is bad bad
bad. sfraser's advice is correct. at least fire it off a timer set to 0, so that
as soon as the handler finishes, you get the event to show the dialog.

Comment 5

[Peter Trudelle]

nsbranch-. This is extremely obscure and undiscoverable (I didn't even know the
feature existed), and I doubt any significant number of users will try this even
once, let alone twice in the same session.

Comment 6

[sairuh (rarely reading bugmail)]

now i am seeing something similar on mac 10.1, using 2001.10.10.04-0.9.4 comm
[branch] bits. here, the dragging the icon to Home results in the following:

1. the Bookmark menu in the personal toolbar might pop open and close
2. then a blank "Set Home Page" dialog appears.
3. however, mousing over the dialog displays the dialog content, which work [can
click buttons to cancel or set the home page].

would this be the same bug, or something else?

Comment 7

[Chris Lyon]

Bug 79040 is the mouse-over dialog content bug.

Comment 8

[sairuh (rarely reading bugmail)]

oops, i should *actually* cc Asa on this. my bad!

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 10

[Paul Chen]

Mass move Ben's bugs dumped on me marked future with p5 to get off my untriaged
radar. You can filter out this email by looking for "ironstomachaussie"

Comment 11

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 12

[Jaime Rodriguez, Jr.]

this causes a crash or hang ... nominating.

Comment 13

[Peter Trudelle]

nsbeta1+ per Nav triage team, ->hewitt?

Comment 14

[Peter Trudelle]

Mass move of nsbeta1+ bugs that didn't have a valid MachV milestone to mozilla1.0.

Comment 15

[Blake Ross]

*** Bug 79040 has been marked as a duplicate of this bug. ***

Comment 16

[Blake Ross]

Attachment: fix, workaround, call it what you will...

Comment 17

[Joe Hewitt (gone)]

Comment on attachment 72319 [details] [diff] [review]
fix, workaround, call it what you will...

sr=hewitt

Comment 18

[Blake Ross]

-> me

Comment 19

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 72319 [details] [diff] [review]
fix, workaround, call it what you will...

i would prefer that |url| is passed to the timer routine, not |aXferData|.
however, the last thing i'd ever want to do is say no to my blakey-poo, so
r=pink.

Comment 20

[Mike Shaver (:shaver emeritus)]

Comment on attachment 72319 [details] [diff] [review]
fix, workaround, call it what you will...

a=shaver for the 1.0 trunk.

Comment 21

[Blake Ross]

fixed.

Comment 22

[Claudius Gayle]

VERIFIED FIxed with 20020308 builds