1040941 - Non-functional "preference" button for Open H264 plugin (depending on state)

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Nils Ohlmeier [:drno]]

Attachment: Screen Shot 2014-07-18 at 1.15.57 PM.png

After the download of the Open H264 plugin the about:addons shows a "Preferences" button left to the drop down menu.
In that state the button is non-functional. If I manually chose "Always Activate" from the drop down menu, the button becomes functional.

I see two options here:
- do not show the button until the plugin is properly installed/activated
- make the button functional even if the plugin is disabled.

Comment 1

[Maire Reavy [:mreavy]]

Georg -- Can I get you help triaging this?  Thanks.

Comment 2

[Maire Reavy [:mreavy]]

I believe this is now a dup for properly enabling/disabling the OpenH264 plugin

Comment 3

[Georg Fritzsche [:gfritzsche]]

Should be fine by now, let me know if there still are issues.

Comment 4

[Nils Ohlmeier [:drno]]

The "Preference" button is visible all the time, no matter in which state the add-on is.
If the add-on is still waiting for download the button is non-functional.
If the add-on is disabled (after successful download) the button is non-functional.

I understand that in both states the actual preferences (if the user wants the plugin to automatically update itself or no) are not meaningful. But I think from a users perspective it is not acceptable to have a button which can be clicked, but does nothing.

I would like to see the "Preferences" button in these two states either somehow disabled, or even better do not show the button if the plugin is not active.

Comment 5

[Maire Reavy [:mreavy]]

Georg -- I believe you're taking this yourself.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Attachment: Make preferences button always work

Users should always be able to disable the auto-update to stay in control, independent of install or enabled state of the plugin.

Blair, looks like we can't avoid patching extensions.js again.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8459550 [details] [diff] [review]
Make preferences button always work

Review of attachment 8459550 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm, yea. At least we'll be able to clean this up sometime in the future.

There's actually two bugs here - the Preferences button shouldn't even have been shown in the first place (bug 1041859). But with this patch, bug 1041859 doesn't affect the OpenH264 plugin.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8974f27e5ed9

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8974f27e5ed9

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8974f27e5ed9

Comment 11

[Marco Mucci [:MarcoM]]

Hi Florin, can a QA contact be assigned for verification of this bug.

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8459550 [details] [diff] [review]
Make preferences button always work

Approval Request Comment
[Feature/regressing bug #]: plugin UI for GMP

[User impact if declined]: Unclickable button shown to users

[Describe test coverage new/current, TBPL]: none

[Risks and why]: fairly low risk; mostly to this button itself

[String/UUID change made/needed]: none

Comment 13

[Marco Mucci [:MarcoM]]

Hi Alexandra, following up to see if this bug can be verified by the end of the iteration on Monday August 4.

Comment 14

[Ada [:adalucinet]]

Reproduced with Nightly 2014-07-21: if the plugin is disabled, Options button is not functional.
Verified as fixed with latest Nightly (Build ID: 20140729030202) on Windows 7 x64, Ubuntu 13.04 x64 and Mac OS X 10.9.4.

Please flip back the [qa+] keyword once this fix lands on Aurora 33.

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2dd9299b843

Comment 16

[Ada [:adalucinet]]

Verified as fixed with latest Aurora 33.0a2 (Build ID: 20140831004002) on Windows 7 64-bit, Mac OS X 10.9.4 and Ubuntu 14.04 32-bit.