1041021 - [B2G][Settings][Downloads]Users can use the "Select" icon when there are no downloads

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Kramer [:Kramer]]

Attachment: Able to edit downloads when there are none.

Description:
Users can still use the select option in Downloads when there are no files. 

Note: This issue is not dependent on device memory.

Prerequisite:
1. Have no downloads on test device. 

Repro Steps:
1) Update a Flame to 20140716000201
2) Open Settings
3) Enter Downloads
4) Press "Select" icon on the top right of the screen
5) Observe the new icons on the bottom of the screen

Actual:
Users can select downloads, but there are no downloads to select. 

Expected:
The "Select" icon is disabled when there are no files to be selected. 

Environmental Variables:
Device: Flame 2.0
Build ID: 20140716000201
Gaia: 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6
Gecko: 913827496f65
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Repro frequency: 100%
See attached: screenshot, video clip ( http://youtu.be/5X-sh6XHOA0 )

Comment 1

[Eric Kramer [:Kramer]]

This issue DOES reproduce on Flame 2.1, Flame 2.0, Flame 1.4, Buri 2.1, Buri 2.0, and Buri 1.4. 

Actual: Users can use the "Select" feature in the Downloads menu when there are no downloads. 

Flame Master
BuildID: 20140717040202
Gaia: Unknown
Gecko: a74600665875
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Buri Master
BuildID: 20140708034259
Gaia: 740faa5d0060fb218b407cf224330654ddf833a5
Gecko: 465280604ea6
Version: 33.0a1 (Master) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Buri 2.0
BuildID: 20140710112849
Gaia: 1bd6e8957ccf310b2f75ba5695b058a2e284df3a
Gecko: 8a86bcf49ef5
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 1.4
BuildID: 20140715000202
Gaia: b7d36622c7df92c976c37520ccab25199c7ada91
Gecko: de7ecfb00955
Version: 30.0 (1.4) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 1.4
BuildID: 20140710073052
Gaia: e273c1f52ed7187e4e0b2d66ed5718f0f20c6eeb
Gecko: 896fa800b72d
Version: 30.0 (1.4) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

You need to specify what memory each Flame device is on including Comment 0.

Comment 3

[Eric Kramer [:Kramer]]

All Flames tested were on 273 Memory. This bug appears on both 273 Flame and 512 Open_C.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Your above statement is not entirely true. You forgot to include the environmental variables for the Flame 2.0(512mb).

Comment 5

[Eric Kramer [:Kramer]]

This issue DOES reproduce on Flame 2.1(273 mem), Flame 2.0(273 mem), Flame 1.4(273 mem).
----------------------------------------------------------------------------------------

This issue DOES repro on Flame 2.0 (512 mem)

Actual: Users can use the "Select" feature in the Downloads menu when there are no downloads.

Flame 2.0 (512 mem)
Build ID: 20140721000201
Gaia: 8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko: 4bd4b0ae7bbe
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 6

[Cameron McCormack (:heycam)]

Attachment: pr

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8462957 [details] [review]
pr

Looks good to me, thank you.

Comment 8

[Aus Lacroix [:aus]]

Is there a particular reason why this hasn't landed yet? :) I've gone ahead and reopened the pull request.

Comment 9

[Aus Lacroix [:aus]]

It looks like the pull request will need to be rebased against master but otherwise it should be fine.

Comment 10

[BMO Automation]

Firefox OS is not being worked on