1041071 - [e10s] Element hiding helper for ABP doesn't work with e10s

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Grant]

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release)
Build ID: 20140718030202

Steps to reproduce:

Hi, EHH doesn't work on e10s.

Comment 1

[Wladimir Palant]

This seems to be related to the error message: "Argument 1 of Document.importNode does not implement interface Node." While there is no line number there, it should be related by this line:

    this.boxElem = doc.importNode(E("ehh-elementmarker").firstElementChild.cloneNode(true), true);

What this does is taking an <html:div> element (a template) from a XUL document, cloning it, then importing it into a content document. My guess it that doc.importNode() sees a wrapper and doesn't recognize it as a DOM node.

We can fix this fairly easy on our end by changing the templating mechanism.

Comment 2

[Wladimir Palant]

I created https://issues.adblockplus.org/ticket/1091 for that. Using a different templating mechanism I can confirm that creating the nodes directly in the content document fixes the issue.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think this bug was mistakenly assigned to me. It's not a regression, but an add-on compat issue that we've had for a while. If the EHH devs can fix it on their end, that would be much better.

Comment 5

[Tracy Walker [:tracy]]

Assignee: :tracy
Link to add-on: https://addons.mozilla.org/en-US/firefox/addon/elemhidehelper/?src=search
Contact info for add-on: [e-mail]
Bug #: This bug 1041071
Add-on ID: [e-mail]
How well does it work?: 90% (data indicates it's in cpow some)
Any obvious performance problems? no
SDK-based: restartless addon
Chromium version: no

Comment 6

[Wladimir Palant]

Yes, there is some remaining CPOW usage when selecting an element, this can also be noticeably slow. There is https://issues.adblockplus.org/ticket/2879 for that, AFAIK the last E10S compatibility issue for Element Hiding Helper.

Comment 7

[mkdante381]

Latest Element Hiding Helper beta, not work with latest AdBlock Plus beta. Again...

Comment 8

[Wladimir Palant]

Works fine for me, so you will need to provide more details. Either way, this pretty certainly has nothing to do with this bug. I think it's best if you file a new bug under https://issues.adblockplus.org/newticket.

Comment 9

[Kostas]

Just wanted to report that, though in https://arewee10syet.com/ it lists EHH v1.3.10 as e10s compatible,
if you launch FF 51 stable x64 in a fresh profile, install only EHH and restart FF,
then unfortunately e10s becomes disabled, as shown in about:support (Multiprocess Windows --> 0/1 (Disabled by add-ons)). 
If I disable EHH and restart FF then e10s becomes enabled again.

Comment 10

[Wladimir Palant]

AFAIK, there is still a separate whitelist for add-ons that won't disable E10S in stable Firefox versions, not every E10S-compatible add-on is accepted.

Comment 11

[Kostas]

Thanks for the information.
Could someone please provide a link to that whitelist?

Comment 12

[Andreas Wagner [:TheOne] [use NI]]

https://dxr.mozilla.org/mozilla-release/rev/84fc5992d31fcb9b26c92bb0054db164720d7fbe/toolkit/mozapps/extensions/internal/E10SAddonsRollout.jsm#192

Comment 13

[Andreas Wagner [:TheOne] [use NI]]

Wladimir, can we close this issue?

Comment 14

[Wladimir Palant]

Isn't it closed already, since 2014? But just in case, next EHH release will work without CPOWs, the necessary changes have been implemented already.

Comment 15

[Andreas Wagner [:TheOne] [use NI]]

Oh yeah it is. Sorry I misread.