104113 - Composer dialog cleanup: Upgrade for XUL 1.0 compliance

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Charles Manske]

New XUL 1.0 features keep appearing every day!
1. For all dialogs, use 
  <dialog
tag instead of 
  <window class="dialog"

2. Use new window attribures such as:
  buttons="accept,cancel" buttonpack="center"
instead of the global overlay inclusions such as:
  <hbox id="okCancelButtonsRight"/>

Comment 1

[[e-mail]]

buttonpack="center"?

Comment 2

[Charles Manske]

Well, we should use whatever 'buttonpack' value seems appropriate.

Comment 3

[Charles Manske]

Attachment: Fix: Mostly convert from '<window class="dialog"' to '<dialog' and related common button changes.

Note that we can't convert the Table Properties dialog to use "<dialog>"
because
it uses an "Apply" button that isn't supported by the <dialog> XBL.

Comment 4

[Charles Manske]

Theres a change to EdColorProps.js ("@@ -346,25 +344,11 @@" in the patch)
that was omitted from the checkin to bug 90229. That change was already reviewed.

Comment 5

[Kathleen :Brade]

I looked over the patch and it looks like onOK isn't renamed to onAccept in
EdDialogTemplate.js.  I didn't check everything so there may be similar problems
besides this.

I'd prefer these changes to happen in stages so they can easily be backed out if
there is a problem.  In particular, I am concerned about <dialog> changes on Mac.

If this all needs to go in at once, then I would like to see it tested on each
primary platform (Mac, Linux, Windows) so problems can be identified before the
checkin.

Comment 6

[Charles Manske]

Change from "onOk" to "onAccept" made in EdDialogTemplate.js. That's just a 
template for new dialogs, which is why I missed it in testing. All dialogs that
are used were tested, of course.
I definitely do want to checkin all of this at once -- I've asked Sujay to 
identifiy any problems with existing dialog that were already converted (e.g,
Image and Link properties). The type of change is the same in all of them, so
testing already-converted dialogs should be sufficient.

Comment 7

[Charles Manske]

Attachment: Updated patch -- fixed a couple of items missed before

Comment 8

[Charles Manske]

Attachment: Update: Remove conflicts with todays update and removed "<popupset>" instances missed by another checkin

Comment 9

[Akkana Peck]

Comment on attachment 60523 [details] [diff] [review]
Update: Remove conflicts with todays update and removed "<popupset>" instances missed by another checkin

Looks okay to me, r=akkana.  I checked with Kathy and she verified that her
concerns have been met, though she didn't have time to review in detail.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 60523 [details] [diff] [review]
Update: Remove conflicts with todays update and removed "<popupset>" instances missed by another checkin

sr=[e-mail]

Comment 11

[Charles Manske]

checked in

Comment 12

[sujay]

 Charley can you verify this one? thanks.

Comment 13

[Charles Manske]

verified