1041181 - Investigate repeated & redundant GMPInstallManager log lines

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Georg Fritzsche [:gfritzsche]]

It might not be any real issue, but log lines (and hence maybe actual activity?) are triggered repeatedly at the end of download/install of openh264.
We should at least check what's going on there.

[...]
1405788611481	GMPExtractor.install	INFO	Installing /Users/gfritzsche/Library/Caches/TemporaryItems/gmp-gmpopenh264.zip...
1405788611494	GMPExtractor.install	INFO	libgmpopenh264.dylib was successfully extracted to: /Users/gfritzsche/Library/Application Support/Firefox/Profiles/r77cq19u.dev3/gmp-gmpopenh264/libgmpopenh264.dylib
1405788611495	GMPExtractor.install	INFO	gmpopenh264.info was successfully extracted to: /Users/gfritzsche/Library/Application Support/Firefox/Profiles/r77cq19u.dev3/gmp-gmpopenh264/gmpopenh264.info
1405788611495	GMPExtractor.install	INFO	/Users/gfritzsche/Library/Caches/TemporaryItems/gmp-gmpopenh264.zip was installed successfully
1405788611496	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.lastUpdate to value: 1405788611
1405788611496	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.lastUpdate to value: 1405788611
1405788611497	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.version to value: 1.0
1405788611497	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.version to value: 1.0
1405788611497	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.version to value: 1.0
1405788611498	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.path to value: /Users/gfritzsche/Library/Application Support/Firefox/Profiles/r77cq19u.dev3/gmp-gmpopenh264
1405788611498	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.path to value: /Users/gfritzsche/Library/Application Support/Firefox/Profiles/r77cq19u.dev3/gmp-gmpopenh264
1405788611498	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.path to value: /Users/gfritzsche/Library/Application Support/Firefox/Profiles/r77cq19u.dev3/gmp-gmpopenh264
1405788611498	GMPPrefs.set	INFO	Setting pref: media.gmp-gmpopenh264.path to value: /Users/gfritzsche/Library/Application Support/Firefox/Profiles/r77cq19u.dev3/gmp-gmpopenh264

Comment 1

[Brian R. Bondy [:bbondy]]

I've noticed too but haven't figured out why yet. It's not actually hitting the code multiple times, it's a log issue only. I think possibly related to the way I'm getting the logger and adding a dump output.   I'll investigate but it's not of high priority.

Comment 2

[Georg Fritzsche [:gfritzsche]]

If it helps to compare, definitely properly working Log.jsm usage here:
http://hg.mozilla.org/mozilla-central/annotate/330ba968ed61/browser/experiments/Experiments.jsm#l130

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: bug1041181.diff

Verified only 1 line of output happens when the log is enabled and 0 when it is not.

Comment 4

[Brian R. Bondy [:bbondy]]

Problem was that it returns the same logger for each name, so each time it returned a logger, it would append another dump on it.

Comment 5

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6563ac17b9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f6563ac17b9

Comment 7

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8462270 [details] [diff] [review]
bug1041181.diff

Approval Request Comment
[Feature/regressing bug #]: OpenH264 integration.
[User impact if declined]: When using test-logging, every logged line will cause more logging line duplicates being printed.
[Describe test coverage new/current, TBPL]: Manual testing, fine on m-c.
[Risks and why]: Low-risk, contained to logging for this being preffed on.
[String/UUID change made/needed]: None.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/683f69c347f1

Comment 9

[u279076]

I do not believe this needs QA verification. Please need-info me if you think otherwise.