104119 - search double escapes for netscape search

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect)

Description

[matt]

search 2.0 does not require UTF-8 to be passed into the query string.  Right now
we are doing this with the netscape sherlock file.  Thus we esccape % to be %25
and it shows up in the search form.

Need to take out UTF-8 as input from sherlock file.

Comment 1

[matt]

Attachment: sherlock diff

Comment 2

[matt]

need reviews.
Pointing to new psp server and also taking input.

Comment 3

[Samir Gehani]

Comment on attachment 52982 [details] [diff] [review]
sherlock diff

r=sgehani.

Comment 4

[Samir Gehani]

Can we get a review/consultation from a netscape.com search engineer?  Todd,
know of any?

Is this going to go in for 0.9.6?

Comment 5

[Todd Pringle]

Myron, is this something that Shawkat could look at?

Comment 6

[Myron Rosmarin]

Attachment: Updated NSCP sherlock file w/o support for UTF-8

Comment 7

[Myron Rosmarin]

I've removed support for UTF-8 in the Netscape Sherlock file and attached it to
this bug report. Please test it and if it flies, put it into the next build and
in the sherlock director on the server at:

http://search.netscape.com/sherlock/SBWeb_01.src

Comment 8

[matt]

To things about that file:
At the bottom the 
updateCheckDays = 1

should be 

updateCheckDays = "1"

and for some reason the the formating is off at the bottom on the file.  Lot's 
of spaces but that won't affect anything.  Also this attachment should be in 
bugscape since it should be in the netscape comm. builds.  I believe I have a 
bug filed with these changes in it.  I'm behind the firewall so I don't know 
the bug number.

Comment 9

[Blake Ross]

Comment on attachment 52982 [details] [diff] [review]
sherlock diff

sr=blake

Comment 10

[matt]

fixed

Comment 11

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]