Closed Bug 1041252 Opened 6 years ago Closed 6 years ago
L10n API use cases in System
System uses some mozL10n.translate and mozL10n.localize both of which are deprecated. The patch will remove the translate (since this is a no-op anyway) and move localize to setAttributes.
Comment on attachment 8459257 [details] [review] pull request Julien, you're a suggested reviewer. Can you take a look at this or reassign to who should look here? It's a fairly trivial patch. It does three things: - localize to setAttributes (or DOM setAttribute if possible) - move tests to test for DOM attribute instead of textContent value - remove mozL10n.translate The last one is the only one which is not automatic. The mozL10n.translate is a no-op anyway, so it will not change any behavior, but we should make sure that MutationObserver does cover it. From my understanding of the code, in these cases it does so I'm removing the call.
Attachment #8459257 - Flags: review?(felash)
Comment on attachment 8459257 [details] [review] pull request Moving to etienne. Etienne, I'm not sure you're the right guy for some of the files, but you're definitely the right guy for some others :)
Attachment #8459257 - Flags: review?(felash) → review?(etienne)
Comment on attachment 8459257 [details] [review] pull request Small comment on github, but all good for the install/udpate parts. Flagging Alive to review the rest :)
Comment on attachment 8459257 [details] [review] pull request \o/
Attachment #8459257 - Flags: review?(alive) → review+
Thanks guys! Commit: https://github.com/mozilla-b2g/gaia/commit/7e8ac12d81270aab9dd14c191de91ddc3cf0f4c2 Merge: https://github.com/mozilla-b2g/gaia/commit/62eedafb0657bbec8941f5bdaa919b5a59f25db1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.