1041252 - Update mozL10n API use cases in System

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

System uses some mozL10n.translate and mozL10n.localize both of which are deprecated.

The patch will remove the translate (since this is a no-op anyway) and move localize to setAttributes.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8459257 [details] [review]
pull request

Julien, you're a suggested reviewer. Can you take a look at this or reassign to who should look here?

It's a fairly trivial patch. It does three things:
 - localize to setAttributes (or DOM setAttribute if possible)
 - move tests to test for DOM attribute instead of textContent value
 - remove mozL10n.translate

The last one is the only one which is not automatic. The mozL10n.translate is a no-op anyway, so it will not change any behavior, but we should make sure that MutationObserver does cover it.

From my understanding of the code, in these cases it does so I'm removing the call.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8459257 [details] [review]
pull request

Moving to etienne. Etienne, I'm not sure you're the right guy for some of the files, but you're definitely the right guy for some others :)

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8459257 [details] [review]
pull request

Small comment on github, but all good for the install/udpate parts.

Flagging Alive to review the rest :)

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8459257 [details] [review]
pull request

\o/

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks guys!

Commit: https://github.com/mozilla-b2g/gaia/commit/7e8ac12d81270aab9dd14c191de91ddc3cf0f4c2
Merge: https://github.com/mozilla-b2g/gaia/commit/62eedafb0657bbec8941f5bdaa919b5a59f25db1