Closed Bug 1041252 Opened 6 years ago Closed 6 years ago

Update mozL10n API use cases in System

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
etienne
: review+
alive
: review+
Details | Review
System uses some mozL10n.translate and mozL10n.localize both of which are deprecated.

The patch will remove the translate (since this is a no-op anyway) and move localize to setAttributes.
Assignee: nobody → gandalf
Blocks: 994519, 1020136
Attached file pull request
Comment on attachment 8459257 [details] [review]
pull request

Julien, you're a suggested reviewer. Can you take a look at this or reassign to who should look here?

It's a fairly trivial patch. It does three things:
 - localize to setAttributes (or DOM setAttribute if possible)
 - move tests to test for DOM attribute instead of textContent value
 - remove mozL10n.translate

The last one is the only one which is not automatic. The mozL10n.translate is a no-op anyway, so it will not change any behavior, but we should make sure that MutationObserver does cover it.

From my understanding of the code, in these cases it does so I'm removing the call.
Attachment #8459257 - Flags: review?(felash)
Comment on attachment 8459257 [details] [review]
pull request

Moving to etienne. Etienne, I'm not sure you're the right guy for some of the files, but you're definitely the right guy for some others :)
Attachment #8459257 - Flags: review?(felash) → review?(etienne)
Comment on attachment 8459257 [details] [review]
pull request

Small comment on github, but all good for the install/udpate parts.

Flagging Alive to review the rest :)
Attachment #8459257 - Flags: review?(etienne)
Attachment #8459257 - Flags: review?(alive)
Attachment #8459257 - Flags: review+
Comment on attachment 8459257 [details] [review]
pull request

\o/
Attachment #8459257 - Flags: review?(alive) → review+
You need to log in before you can comment on or make changes to this bug.