1041253 - Review request change summaries not mirrored to Bugzilla

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mark Côté [:mcote]]

If you include a comment when changing a review request, when, say, publishing a new patch, that comment is not mirrored over.

Example is https://reviewboard-dev.allizom.org/r/69/; when the review request was changed on July 18, 2014, 3:45 pm (off-topic: I think the server time is wrong...), the comment starting with "I noticed that ..." was not mirrored over when the new review flag was set.

Comments when closing a review request aren't mirrored over either (note that we should probably ensure that only the squashed request can be closed, and that it closes its dependent requests).

Comment 1

[Mark Côté [:mcote]]

Attachment: Review for review ID: bz://1041253

/r/77 - Bug 1041253 - [rbbz] Include change description when publishing review request.

Comment 2

[Steven MacLeod [:smacleod]]

Looks fine to me. Just a comment about styling of the bugzilla comment we cross post.

::: pylib/rbbz/rbbz/extension.py
(Diff revision 1)
> +            comment += '\n%s' % review_request_draft.changedesc.text

if `review_request_draft.description` has a trailing new lines, this is fine.

If it does not though, could you add two new lines, so that we have a blank line between.

I also wonder if we should add some sort of title to this section when appending it. Maybe "Description of change:" or "Notes:"? I really don't feel strongly about this though, so only add it if you feel it's best.

Comment 3

[Mark Côté [:mcote]]

::: pylib/rbbz/rbbz/extension.py
(Diff revision 1)
> +            comment += '\n%s' % review_request_draft.changedesc.text

> if `review_request_draft.description` has a trailing new lines, this is fine.

If it does not though, could you add two new lines, so that we have a blank line between.

I also wonder if we should add some sort of title to this section when appending it. Maybe "Description of change:" or "Notes:"? I really don't feel strongly about this though, so only add it if you feel it's best.
Fixed to add an extra newline if description doesn't end with a newline.

I don't think we need any extra title; it seems pretty clear, and updating patches in Bugzilla doesn't add any extra either.

Comment 4

[Mark Côté [:mcote]]

Hm our comment formatting appears a bit broken, though... filed bug 1043737.

Comment 5

[Mark Côté [:mcote]]

http://hg.mozilla.org/hgcustom/version-control-tools/rev/cba5e0c57f70