Closed Bug 1041262 Opened 5 years ago Closed 5 years ago

[Perma Orange] TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Didn't find the current result ('amazon.com', 'Amazon.com') in matches - See following stack:

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox33 --- fixed
firefox34 --- fixed
firefox35 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: philip.chee, Assigned: hiro)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

Possible causes:
Bug 1020440 - Create DOM interfaces and stub for requestAutocomplete
Bug 1023484 - Improvements and test for the initial requestAutocomplete stub
1020865 - Implement the dialog displayed upon form.requestAutocomplete()

https://tbpl.mozilla.org/php/getParsedLog.php?id=44169628&tree=Thunderbird-Trunk#error0

TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_416211.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_autocomplete_on_value_removed_479089.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception TypeError: Cc['@mozilla.org/autocomplete/search;1?name=unifiedcomplete'] is undefined at C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/test_autocomplete_on_value_removed_479089.js:16 - See following stack:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_422277.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_416214.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 2 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_417798.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_casing.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Autofilled value is correct - "MOZ" == "MOZilla.org/" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_autocomplete_functional.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Autofilled value is correct - "vis" == "visit2.mozilla.org/" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_418257.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_dupe_urls.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_download_embed_bookmarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_escape_self.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_enabled.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_ignore_protocol.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_match_beginning.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_keyword_search.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_keywords.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Autofilled value is correct - "moz" == "mozilla.org/" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_empty_search.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 6 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_queryurl.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Autofilled value is correct - "file" == "file.org/" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_swap_protocol.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 6 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_tabmatches.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception TypeError: Cc['@mozilla.org/autocomplete/search;1?name=unifiedcomplete'] is undefined at C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js:212 - See following stack:
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_trimming.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Autofilled value is correct - "mo" == "mozilla.org/" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_multi_word_search.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_typed.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Autofilled value is correct - "moz" == "mozilla.org/" - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_word_boundary_search.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 4 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_special_search.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | C:/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Got as many results as expected - 0 == 6 - See following stack:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | Unexpected exception 2147500036
So a large fraction of the failures were due to files not getting packaged in the manifests. I fixed that by adding the manifest changes, but a smaller number of them persist in failing. Updating the summary to reflect the failing tests.
Component: Build Config → Places
Product: Thunderbird → Toolkit
Summary: [Perma Orange] TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\toolkit\components\places\tests\unifiedcomplete\test_416211.js | test failed (with xpcshell return code: 0), see following log: → [Perma Orange] TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Didn't find the current result ('amazon.com', 'Amazon.com') in matches - See following stack:
(In reply to Joshua Cranmer [:jcranmer] from comment #1)
> So a large fraction of the failures were due to files not getting packaged
> in the manifests. I fixed that by adding the manifest changes, but a smaller
> number of them persist in failing. Updating the summary to reflect the
> failing tests.

You might need this as well:
+@BINPATH@/components/toolkit_formautofill.xpt
For reference, the manifest changes was pushed as https://hg.mozilla.org/comm-central/rev/4544530f1c81
The failures remaining - those in unified autocomplete, were introduced in bug 993372, specifically part 2:

http://hg.mozilla.org/mozilla-central/rev/b16a100a246f

Unfortunately I don't see why our stuff is failing and m-c isn't.

AFAICT Thunderbird is using the same browser.urlbar pref defaults, I've even tried copying those from firefox.js to all-thunderbird.js.
Blocks: 993372
some of the failures in unifiedcomplete might be related to search engines that are in Firefox and not elsewhere. We started suggesting based on searchEngines and that might indeed be problematic if the engines differ. We should probably add custom search engines manually in the head file and use those for the tests.
Sorry for comment 33. The bug number in my commit message was wrong. Please ignore.
https://hg.mozilla.org/mozilla-central/rev/f552c962fea3
Assignee: nobody → jorendorff
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Assignee: jorendorff → nobody
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla34 → ---
Status: REOPENED → NEW
(In reply to Mark Banner (:standard8) from comment #31)
> The failures remaining - those in unified autocomplete, were introduced in
> bug 993372, specifically part 2:
> 
> http://hg.mozilla.org/mozilla-central/rev/b16a100a246f
> 
> Unfortunately I don't see why our stuff is failing and m-c isn't.

It's because searchplugins is in dist/bin/browser/ on m-c. On c-c searchplugins is in dist/bin/.
(In reply to Hiroyuki Ikezoe (:hiro) from comment #36)
> (In reply to Mark Banner (:standard8) from comment #31)
> > The failures remaining - those in unified autocomplete, were introduced in
> > bug 993372, specifically part 2:
> > 
> > http://hg.mozilla.org/mozilla-central/rev/b16a100a246f
> > 
> > Unfortunately I don't see why our stuff is failing and m-c isn't.
> 
> It's because searchplugins is in dist/bin/browser/ on m-c. On c-c
> searchplugins is in dist/bin/.

Have you tested it? I'd be surprised if it is that, as searchplugins directory is a standard dir and should be defined correctly for TB and FF. I can't see any test code that's overriding that, and the "firefox-appdir" definitions should only be for FF.

I've tried a few things, including copying all the search engines from Firefox, and it doesn't seem to have worked yet.
(In reply to Mark Banner (:standard8) from comment #37)

> I've tried a few things, including copying all the search engines from
> Firefox, and it doesn't seem to have worked yet.

The main problem there is that some plugins exist in dist/bin/searchplugins/. You has to remove all plugins from the directory.
Here is what I think is going on.

The 'amazon.com' entries are occurring because Thunderbird xpcshell has the search provider directory "SrchPluginsDL" defined, while the firefox xpcshell does not. I traced through the loading of it all, and confirmed that. The search directories get defined in the modules, nsMailComps.cpp for the Thunderbird case, and browser/components/build/nsModule.cpp (aka "kBrowserModule" or "browsercomps") for Firefox. So how are they different? browsercomps is not in lib xul, it is defined:

XPCOMBinaryComponent('browsercomps')

and packaged separately as browsercomps.dll and included in a manifest so it is packaged. The equivalent Thunderbird file is in libxul. For that reason (or so I believe) the Firefox search providers do not get installed by default in xpcshell, while the equivalent Thunderbird providers do. Therefore Thunderbird xpcshell has an Amazon provider, and searches for "a" show that, while they do not in Firefox xpcshell.

I suppose to match Firefox we need to break out the DirectoryProvider in Thunderbird from xul, and load it separately when Thunderbird starts. I have not figured out yet how Firefox loads its browsercomps module separately from libxul on startup, but we would need to do the same thing.
Is there any reason that Thunderbird needs search provider definitions at all? I'm pretty sure that I could make he XPCSHELL test pass by simply removing the search provider directory from the mail module. If we do need this, then we'll need an alternate way to connect this directory provider to Thunderbird but not xpcshell
Thunderbird has at leat two places where search plugins may be used - from the right-click menu and from the global search bar.

I think seperating out the files into a library would be going too far. It would be simpler to fix the test than doing that.
Based on that, I think by setting browser.autoFill.searchEngines to false in the failing tests you should be able to fix them.
Attached patch Possible fix (obsolete) — Splinter Review
This patch creates a dummy empty cache file to avoid loading search engines from dist/bin/searchplugins/.
Almost codes was copied from toolkit/components/search/tests/xpcshell/test_json_cache.js and toolkit/components/search/tests/xpcshell/head_search.js.

Try server results:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=c9dd8c65c139

The patch on the try is a bit difference from the patch I am attaching. The differences are:

* using gProfD instead of do_get_profile()
* the dummy cache file is removed when each test file is finished.
Attachment #8485655 - Flags: review?(mak77)
(In reply to Marco Bonardo [:mak] (needinfo? me) from comment #42)
> Based on that, I think by setting browser.autoFill.searchEngines to false in
> the failing tests you should be able to fix them.

Setting the preference value does not fix this failure on my local linux...
(In reply to Hiroyuki Ikezoe (:hiro) from comment #44)
> (In reply to Marco Bonardo [:mak] (needinfo? me) from comment #42)
> > Based on that, I think by setting browser.autoFill.searchEngines to false in
> > the failing tests you should be able to fix them.
> 
> Setting the preference value does not fix this failure on my local linux...

that's strange, the code is completely skipped if that pref is set
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/UnifiedComplete.js#727

I think we should figure why doesn't work there, rather than introducing very complicate code that might give us more issues or compatibility problems in future.
Ah I see the problem, the pref is

browser.urlbar.autoFill.searchEngines

sorry for the mistake.
Thanks Marco! Now all failure tests passed on my local.

I just pushed a try now:
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=38772b264823
Attachment #8485655 - Attachment is obsolete: true
Attachment #8485655 - Flags: review?(mak77)
Comment on attachment 8485665 [details] [diff] [review]
Setting "browser.urlbar.autoFill.searchEngines"

try server result seems good.
Attachment #8485665 - Flags: review?(mak77)
Comment on attachment 8485665 [details] [diff] [review]
Setting "browser.urlbar.autoFill.searchEngines"

Review of attachment 8485665 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this looks fine.

::: toolkit/components/places/tests/unifiedcomplete/test_417798.js
@@ +14,5 @@
>    addBookmark({ uri: uri2,
>                  title: "Title with javascript:" });
>  
>    do_log_info("Match non-javascript: with plain search");
> +  Services.prefs.setBoolPref("browser.urlbar.autoFill.searchEngines", false);

since cleanup() runs only at the end of the whole test, and once you set the pref it will be valid for any following test in the same file, please just set the pref immediately after add_task, so that it's set for all the tests in the file.

In this case

add_task(function* test_javascript_match() {
  <== here!
  let uri1 = NetUtil.newURI("http://abc/def");


the other prefs we set in these tests usually are set only for a subset of the tests so they are in the middle of the test for a reason.

::: toolkit/components/places/tests/unifiedcomplete/test_match_beginning.js
@@ +14,5 @@
>                             { uri: uri2, title: "b a" } ]);
>  
>    do_log_info("Match at the beginning of titles");
>    Services.prefs.setIntPref("browser.urlbar.matchBehavior", 3);
> +  Services.prefs.setBoolPref("browser.urlbar.autoFill.searchEngines", false);

ditto

::: toolkit/components/places/tests/unifiedcomplete/test_word_boundary_search.js
@@ +43,5 @@
>    addBookmark( { uri: uri6, title: "title1", tags: [ "dontmatchme3" ] } );
>  
>    // match only on word boundaries
>    Services.prefs.setIntPref("browser.urlbar.matchBehavior", 2);
> +  Services.prefs.setBoolPref("browser.urlbar.autoFill.searchEngines", false);

ditto
Attachment #8485665 - Flags: review?(mak77) → review+
Carrying over review+.
Attachment #8485665 - Attachment is obsolete: true
Attachment #8486300 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/be02154bdec2
Assignee: nobody → hiikezoe
Keywords: checkin-needed
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/be02154bdec2
Status: NEW → RESOLVED
Closed: 5 years ago5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Keywords: checkin-needed
I am sorry for wrong keywords.
I'm not sure this has worked on beta, any ideas?

https://tbpl.mozilla.org/?tree=Thunderbird-Beta&rev=7a9679f99e14

We can survive without it if it isn't an easy fix, just surprised more than anything.
in beta browser.urlbar.autoFill.searchEngines pref didn't exist yet... I guess the only way is to skip the tests there. I'd be fine with that since unifiedcomplete was not even enabled there.
(In reply to Marco Bonardo [:mak] (needinfo? me) from comment #56)
> in beta browser.urlbar.autoFill.searchEngines pref didn't exist yet... I
> guess the only way is to skip the tests there. I'd be fine with that since
> unifiedcomplete was not even enabled there.

Ok, lets not bother, that version of TB won't be released (apart from to beta), and we can cope with the test failures for the beta cycle.
It's not clear to me that the new failures are the same as the old. I think there needs to be a new bug.
(In reply to Kent James (:rkent) from comment #61)
> It's not clear to me that the new failures are the same as the old. I think
> there needs to be a new bug.

You're probably right.
> TEST-UNEXPECTED-FAIL | C:/slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unifiedcomplete/head_autocomplete.js | Didn't find the current result ('moz-action:searchengine,{"engineName":"Bing","input":"visited/v","searchQuery":"visited/v"}', 'Bing') in matches - See following stack:
Wild guess: Does TB package the unified autocomplete components?
Filed bug 1082294.
You need to log in before you can comment on or make changes to this bug.