1041311 - Fix Qt compilation (Make destructors of NS_*_INLINE_* refcounted classes non-public)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tom S [:evilpie]]

Attachment: v1

Comment 1

[Oleg Romashin (:romaxa)]

Comment on attachment 8459305 [details] [diff] [review]
v1

># HG changeset patch
># Parent 4515815020907e84660259ea993287bd84058855

Plz add bug number and description to the patch header  (hg qrefresh -U -m "....")
> 
>+NS_IMETHODIMP
>+nsScreenManagerQt::ScreenForId(uint32_t aId, nsIScreen **aOutScreen)

nsScreenManagerQt::ScreenForId(uint32_t aId, nsIScreen** aOutScreen)
                                                      ^

>+{
>+    if (!mInitialized)
>+        init();

   if (!mInitialized) {
        init();
   }

> NS_IMETHODIMP
>+nsScreenQt::GetId(uint32_t *aId)

nsScreenQt::GetId(uint32_t* aId)

Comment 2

[Tom S [:evilpie]]

Attachment: v2

I never include bug info into my patches and I was just maintaining the local style.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5f3d2f7bc4e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5f3d2f7bc4e