1041314 - translation bar will block other tips

Status: RESOLVED INVALID

(Firefox :: Translations, defect)

Description

[leichixian]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release)
Build ID: 20140720030203

Steps to reproduce:

1.make the value of "browser.translation.ui.show" is true;
2.Visit a page not in my language(eg., a Chinese visiting a French site);
3.Use other addons that will show a tip on the top of the window(eg., easyscreenshot and choose "selected region").


Actual results:

The translation bar will block tip of easyscreenshot.


Expected results:

They both need to be shown.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Can you provide an screenshot of the problem?

Comment 2

[leichixian]

Attachment: screen captures about this bug

This describes the bug. For example, I'm a Chinese user and I'm visiting this site which is written in English, and I used easyscreenshot to get a capture, there is a tip like picture 2, but now it was blocked by the translation bar like picture 1.

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

Attachment: 捕获.PNG

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

Attachment: 捕获1.PNG

Comment 5

[Bogdan Maris, Desktop QA [Holiday+PTO 1-6 May]]

I can confirm this using en build (latest Nightly 34.0a1) and visiting https://addons.mozilla.org/en-US/firefox/addon/easyscreenshot/ website which has Chinese characters and triggers the translation infobar.

Comment 6

[Florian Quèze [:florian]]

(In reply to leichixian from comment #0)

> Expected results:
> 
> They both need to be shown.

I think it's by design that only one notification bar is shown at once.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

This is not specific to translation. The infobar system only supports displaying one notification at once, and when more than one is requested, they are displayed in an specified order of priority. The translation infobar seems to have a higher priority than the one that the add-on is adding, and is therefore the one displayed.

I wonder if we should reduce the translation infobar priority from high to medium, but in any case it doesn't fully resolve this problem. Perhaps this bug should be marked as "add-on compat", or morphed into "support displaying more than 1 infobar at once". The infobar is not heavily used at this moment, but this might become more important if translation goes for a wider release.

Comment 8

[leichixian]

(In reply to :Felipe Gomes (away Jul 23 - Aug 13) from comment #7)
> This is not specific to translation. The infobar system only supports
> displaying one notification at once, and when more than one is requested,
> they are displayed in an specified order of priority. The translation
> infobar seems to have a higher priority than the one that the add-on is
> adding, and is therefore the one displayed.
> 
> I wonder if we should reduce the translation infobar priority from high to
> medium, but in any case it doesn't fully resolve this problem. Perhaps this
> bug should be marked as "add-on compat", or morphed into "support displaying
> more than 1 infobar at once". The infobar is not heavily used at this
> moment, but this might become more important if translation goes for a wider
> release.

Maybe you can make the icon in the address bar give a popup window to ask whether the user need translate this page or not, and show the progress, like what you can enable in chrome now.

Comment 9

[Greg Tatum [:gregtatum]]

The new implementation doesn't use an infobar.