1041316 - Host search redirection notification bar disappears in case of multipart response by the search engine

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P3)

Description

[Jose Fandos]

Typing "localhost" in the URL bar should load the localhost page on the local machine. Instead it loads google.com with a search for "localhost"

Trying other entries that are in the host file of my os, e.g. local.example.com and which are pointing to a folder in local drive, go to a "server not found" error message page.

Chrome and Safari, on the same computer, work as expected. This was working yesterday, so likely a change in the latest nightly.

Comment 1

[WaltS48 [:walts48]]

Loads Startpage for me with a search for "localhost".

Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140719030203 CSet: 35f3fa435d2c

Get the "Firefox can't establish a connection to the server at localhost." problem loading page using Firefox 30.0 and Firefox 31.0 RC2, when I enter "localhost" in the URL bar.

I don't have a local server installed.

Comment 2

[Peja Stija]

Don't know if it's related but having configured a proxy on localhost (such as proxomitron on port 8080) gives only "Unable to find the proxy server" errors after using them for some minutes.

Comment 3

[Marty]

Same trouble here connecting with localhost 8080 except that checking "Use this proxy sever for all protocols" seems to fix it. The only problem with that solution is that it's forcing us to use the proxy for all the protocols. I only want it setup to work with HTTP as before.

Comment 4

[u428464]

Should block bug 693808

Comment 5

[Jose Fandos]

It appears that the error is intermittent. After some further testing, this works and then doesn't and then I can get it to work again after a while. Other browsers in same machine work all the time, though.

Comment 6

[Marco Bonardo [:mak]]

after bug 693808 we load search results first unless the host is in a whitelist. localhost is in the whitelist by default, any other local domain should show you a notification bar asking if you want to visit the local host.
please verify you have browser.fixup.domainwhitelist.localhost set to true.

just in case please try in safe mode: https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 7

[Sören Hentzschel]

(In reply to Marco Bonardo [:mak] from comment #6)
> after bug 693808 we load search results first unless the host is in a
> whitelist. localhost is in the whitelist by default, any other local domain
> should show you a notification bar asking if you want to visit the local
> host.

Yes, but the notification bar dissapears after the redirect, I have no chance to click a button…

Comment 8

[Sören Hentzschel]

(In reply to Sören Hentzschel from comment #7)
> Yes, but the notification bar dissapears after the redirect, I have no
> chance to click a button…

It works with Google as search engine, though. But Google is not my default search engine. With Bugzilla as selected search engine the notification bar is not usable.

Comment 9

[Marty]

browser.fixup.domainwhitelist.localhost is set true. Is the fact that I can no longer connect with localhost 8080 unless "Use this proxy server for all protocols" is checked related to your patch and is it intentional behavior? I do not want to use FTP with the local proxy but am now being forced to.

Comment 10

[Marco Bonardo [:mak]]

Please note that bug 354493 landed the same exact day, that makes visiting a local host with a custom port behave differently ,depending on the page you were on before. I think some of the reported issues with custom ports (8080) here may be rather due to that change.

The only manifestation of a bug here is that we might read a search engine page instead of a local host page and NOT show a notification bar to revert the operation.

(In reply to Sören Hentzschel from comment #7)
> (In reply to Marco Bonardo [:mak] from comment #6)
> > after bug 693808 we load search results first unless the host is in a
> > whitelist. localhost is in the whitelist by default, any other local domain
> > should show you a notification bar asking if you want to visit the local
> > host.
> 
> Yes, but the notification bar dissapears after the redirect, I have no
> chance to click a button…

Ok, this is indeed something to consider, if the engine redirects it should not dismiss the notification bar.

Comment 11

[Marco Bonardo [:mak]]

So, if your issue is with a custom port and your problem is not about having default search engine page searching for the local host name, please file a separate bug and tentatively block bug 354493, this is not the right bug report.

Comment 12

[Marco Bonardo [:mak]]

(In reply to Sören Hentzschel from comment #8)
> (In reply to Sören Hentzschel from comment #7)
> > Yes, but the notification bar dissapears after the redirect, I have no
> > chance to click a button…
> 
> It works with Google as search engine, though. But Google is not my default
> search engine. With Bugzilla as selected search engine the notification bar
> is not usable.

could you please post your steps to reproduce the bug, since I just tried to ser bugzilla as search engine, I type 12345 in the the locationbar, I hit enter and I get both the bug loaded and the notificationbar, it sticks even after the redirect.

Comment 13

[:Gijs (he/him)]

(In reply to Marco Bonardo [:mak] from comment #11)
> So, if your issue is with a custom port and your problem is not about having
> default search engine page searching for the local host name, please file a
> separate bug and tentatively block bug 354493, this is not the right bug
> report.

NB: tracked in bug 1041511.

Comment 14

[Sören Hentzschel]

(In reply to Marco Bonardo [:mak] from comment #12) 
> could you please post your steps to reproduce the bug, since I just tried to
> ser bugzilla as search engine, I type 12345 in the the locationbar, I hit
> enter and I get both the bug loaded and the notificationbar, it sticks even
> after the redirect.

Okay, that's interesting. A number works with Bugzilla as selected search engine, but not a local host. With Google as selected search engine both works.

STR:

1. set up a local host. Instead of 'localhost' I have different hostnames for different projects.
2. select Bugzilla as search engine
3. type your hostname in the url bar and press enter, for example 'test'

Expected:

There should be a notification bar with the text "Did you mean to go to test?" with two buttons. Use Google as search engine and it works.

Actual:

There is the notification bar with the two buttons, but the notification bar disappers after the "dino animation" of Bugzilla.

Comment 15

[:Gijs (he/him)]

(In reply to Sören Hentzschel from comment #14)
> (In reply to Marco Bonardo [:mak] from comment #12) 
> > could you please post your steps to reproduce the bug, since I just tried to
> > ser bugzilla as search engine, I type 12345 in the the locationbar, I hit
> > enter and I get both the bug loaded and the notificationbar, it sticks even
> > after the redirect.
> 
> Okay, that's interesting. A number works with Bugzilla as selected search
> engine, but not a local host. With Google as selected search engine both
> works.
> 
> STR:
> 
> 1. set up a local host. Instead of 'localhost' I have different hostnames
> for different projects.
> 2. select Bugzilla as search engine
> 3. type your hostname in the url bar and press enter, for example 'test'
> 

I can reproduce this just by toggling the localhost pref to false for testing purposes, too.

I think we should just make the persistence stuff in the notification binding ignore redirects for its decrementing routine, but I don't know how hard it is to do that.

Comment 16

[:Gijs (he/him)]

Shouldn't be too hard (famous last words) assuming some of the stuff available in http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4168 indicates whether or not this was caused by a redirect...

Comment 17

[:Gijs (he/him)]

So bugzilla uses multipart responses. It turns out onLocationChange fires multiple times with the same URI, once for each part. I don't think that makes sense, but Neil said that maybe it does?

In any case, AFAICT none of the things in here:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4168

should be firing when anything but the first part of the document is loaded.

However, I can't find a way to detect a multipart document on the JS side of things.

Comment 18

[Florencia Di Ciocco, NI to vbalducci]

Hi, I think that this bug is no longer valid in the face of latest changes on the browser. If I'm mistaken, please reopen it.
Regards, Flor.