1041326 - Add clang-cl support to the NSS build system

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[(no longer active)]

This enables NSS to detect the version of MSVC that clang-cl pretends to
support, and it also enables the usage of the -mssse3 flag for
intel-gcm-wrap.c which uses SSSE3 intrinsics.

Comment 1

[(no longer active)]

Attachment: Add clang-cl support to the NSS build system

Comment 2

[(no longer active)]

ping?

Comment 3

[(no longer active)]

ping again?

Comment 4

[(no longer active)]

Wan-Teh, any chance you could look at this, please?

Comment 5

[Wan-Teh Chang]

Attachment: Add clang-cl support to the NSS build system, by Ehsan Akhgari, v2

Ehsan: I'm sorry this fell through the cracks.

I reformatted the code a bit and checked it in:
https://hg.mozilla.org/projects/nss/rev/ad4f3b2b5897

I will push this to mozilla-central next week.

Comment 6

[(no longer active)]

Thanks a lot, Wan-Teh!

Comment 7

[(no longer active)]

This was merged in https://hg.mozilla.org/integration/mozilla-inbound/rev/e1c5c185b707.  Marking it as FIXED since that revision is green and I don't know if mcMerge will correctly deal with this.

Comment 8

[Wan-Teh Chang]

Comment on attachment 8481718 [details] [diff] [review]
Add clang-cl support to the NSS build system, by  Ehsan Akhgari, v2

Patch (as part of NSS_3_17_1_BETA2) pushed to mozilla-central:
https://hg.mozilla.org/mozilla-central/rev/e1c5c185b707