Closed Bug 1041363 Opened 11 years ago Closed 11 years ago

Intermittent test_preload_actions.html | (19) preload is initially auto - got false, expected true | (19) no buffering has taken place - got false, expected true

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
firefox-esr31 --- unaffected
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: RyanVM, Assigned: jwwang)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

1041363_fix_test_preload_actions_html_test19.patch
2.51 KB, patch
cpearce
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=44231709&tree=Mozilla-Inbound Android 2.3 Emulator mozilla-inbound opt test mochitest-5 on 2014-07-20 14:09:21 PDT for push b00c22ac9b23 slave: tst-linux64-spot-758 14:59:37 INFO - 2817 INFO [finished test16-13] remaining= test17-14 | undefined 14:59:37 INFO - 2818 INFO TEST-PASS | /tests/content/media/test/test_preload_actions.html | [finished test16-13] Length of array should match number of running tests 14:59:37 INFO - 2819 INFO TEST-PASS | /tests/content/media/test/test_preload_actions.html | (17) Got playback ended. 14:59:37 INFO - 2820 INFO [finished test17-14] remaining= | undefined 14:59:37 INFO - 2821 INFO TEST-PASS | /tests/content/media/test/test_preload_actions.html | [finished test17-14] Length of array should match number of running tests 14:59:37 INFO - 2822 INFO TEST-PASS | /tests/content/media/test/test_preload_actions.html | [started test18-15] Length of array should match number of running tests 14:59:37 INFO - 2823 INFO TEST-PASS | /tests/content/media/test/test_preload_actions.html | [started test19-16] Length of array should match number of running tests 14:59:37 INFO - 2824 INFO TEST-PASS | /tests/content/media/test/test_preload_actions.html | (19) preload is initially auto 14:59:37 INFO - 2825 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_preload_actions.html | (19) preload is initially auto - got false, expected true 14:59:37 INFO - TEST-INFO | expected PASS 14:59:37 INFO - 2826 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_preload_actions.html | (19) no buffering has taken place - got false, expected true 14:59:37 INFO - TEST-INFO | expected PASS 14:59:37 INFO - 2827 INFO TEST-OK | /tests/content/media/test/test_preload_actions.html | took 94353ms
Assignee: nobody → jwwang
Depends on: 984259
Here is the story: 1. When preload is set to 'none' at [1], chances are we are still downloading and |mPreloadAction| remains PRELOAD_METADATA due to the rule specified at [2]. 2. Setting the 'src' attribute at [3] will trigger HTMLMediaElement::AbortExistingLoads() which doesn't call UpdatePreloadAction(). 3. By the time UpdatePreloadAction() is called in SelectResource(), |mBegun| is true and rule [2] kicks in again. We end up having |mPreloadAction==PRELOAD_METADATA|. 4. 'loadedmetadata' fires again and test at [4] fails due to preload is 'none'. Bug 984259 will fix the problem listed above. However, I would like to remove the usage of timer to make the test more reliable in this bug. [1] http://hg.mozilla.org/mozilla-central/file/b85c260821ab/content/media/test/test_preload_actions.html#l576 [2] http://hg.mozilla.org/mozilla-central/file/b85c260821ab/content/html/content/src/HTMLMediaElement.cpp#l1075 [3] http://hg.mozilla.org/mozilla-central/file/b85c260821ab/content/media/test/test_preload_actions.html#l577 [4] http://hg.mozilla.org/mozilla-central/file/b85c260821ab/content/media/test/test_preload_actions.html#l573
Comment on attachment 8499395 [details] [diff] [review] 1041363_fix_test_preload_actions_html_test19.patch Try: https://tbpl.mozilla.org/?tree=Try&rev=10e13e3f39bf https://tbpl.mozilla.org/?tree=Try&rev=2a2250d5be1a All green.
Attachment #8499395 - Flags: review?(cpearce)
Attachment #8499395 - Flags: review?(cpearce) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de956d0e0c46
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: