1041394 - Refine NetworkUtils::ExecuteCommand to table driven

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

Since NetworkUtils::ExecuteCommand [1] is going to handle 
more and more commands because of Bug 1038531, we need to
make it cleaner and easier to expand. Introducing a table-drive
matching is a good substitute.

[1] http://hg.mozilla.org/mozilla-central/file/4bafe35cfb65/dom/system/gonk/NetworkUtils.cpp#l1092

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug1041394.patch

Comment 2

[Henry Chang [:hchang]]

Comment on attachment 8459396 [details] [diff] [review]
Bug1041394.patch

Try run: https://tbpl.mozilla.org/?tree=Try&rev=f52bdda26cec

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8459396 [details] [diff] [review]
Bug1041394.patch

Review of attachment 8459396 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.

Comment 4

[Henry Chang [:hchang]]

(In reply to Vincent Chang[:vchang] from comment #3)
> Comment on attachment 8459396 [details] [diff] [review]
> Bug1041394.patch
> 
> Review of attachment 8459396 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good. Thank you.

Thanks! I also verified on devices. Going to flag 'checkin-needed'. Thanks.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fc923f136111

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fc923f136111