1041424 - [mozrunner] Improve exception when instantiating B2GDeviceRunner with no devices attached/detected

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

If ADB cannot detect any devices we should give a helpful message suggesting that none were found instead of the current IndexError: list index out of range:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/mozbase/mozrunner/mozrunner/base/device.py", line 69, in start
    self.device.connect()
  File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/mozbase/mozrunner/mozrunner/devices/base.py", line 127, in connect
    serial = self.serial or self._get_online_devices()[0]
IndexError: list index out of range

To replicate:
from mozrunner import B2GDeviceRunner
B2GDeviceRunner().start()

Comment 1

[James Graham [:jgraham]]

Attachment: Raise a helpful exception if B2GDeviceRunner is used with no devices attached.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8459561 [details] [diff] [review]
Raise a helpful exception if B2GDeviceRunner is used with no devices attached.

Review of attachment 8459561 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

Comment 3

[James Graham [:jgraham]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc2a2ee82f10

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc2a2ee82f10