1041453 - MediaCodecReader crashes while parsing / playing some WebM files.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bruce Sun [:brsun]]

Gecko got crash while parsing / playing Vorbis data in WebM in some cases:
 - https://github.com/mozilla-b2g/platform_frameworks_av/blob/master/media/libstagefright/codecs/vorbis/dec/SoftVorbis.cpp#L274

It seems we have to do extra efforts to handle Vorbis data:
 - https://github.com/mozilla-b2g/platform_frameworks_av/blob/master/media/libstagefright/OMXCodec.cpp#L3128
 - https://github.com/mozilla-b2g/platform_frameworks_av/blob/master/media/libstagefright/NuMediaExtractor.cpp#L472

Comment 1

[Bruce Sun [:brsun]]

One WebM example to make gecko crash after enabling MediaCodecReader:
 - https://bugzilla.mozilla.org/show_bug.cgi?id=823646#c2
 - http://www.quirksmode.org/html5/videos/big_buck_bunny.webm

Comment 2

[Bruce Sun [:brsun]]

Attachment: bug1041453_media_codec_reader_vorbis_crash.patch

Append the queried value of |kKeyValidSamples| to the end of each vorbis input buffer.

Comment 3

[Bruce Sun [:brsun]]

Attachment: bug1041453_media_codec_reader_vorbis_crash.checkin.patch

https://tbpl.mozilla.org/?tree=Try&rev=009bafb08174

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/039d4e5c03b9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/039d4e5c03b9