1041469 - Remove Latin1 strings flag

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Some patches I want to land after the merge today or tomorrow.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - rm EnableLatin1Strings

AtomizeAndtake [sic] is no longer used so this patch removes it too.

 6 files changed, 8 insertions(+), 159 deletions(-)

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - rm NewFatInlineString duplication

With the previous patch, the Latin1Char/jschar overloads are now almost the same so we can use templates instead.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - rm toLatin1 function, update tests

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 4 - Use Latin1Char in StaticStrings::init

NewStringCopyN deflated jschar so this doesn't change much, but it's slightly more efficient to pass Latin1Char directly.

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Part 4 - Use Latin1Char in StaticStrings::init

(Add a static_assert.)

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Part 5 - Make escape() allocate Latin1Char*

With the flag gone, escape() can directly allocate a Latin1Char* for the result (with jschar*, NewString always deflated).

Comment 7

[Jan de Mooij [:jandem]]

The --latin1-strings shell flag is still there but it's a NOP now. Gary, please let me know when I can remove it; I don't want to break the fuzzers while you're on PTO.

Comment 8

[Jan de Mooij [:jandem]]

Parts 1-3:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca98d496cd34
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb95b5ac197a
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c4509cb7661

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ca98d496cd34
https://hg.mozilla.org/mozilla-central/rev/eb95b5ac197a
https://hg.mozilla.org/mozilla-central/rev/3c4509cb7661

Comment 10

[Jan de Mooij [:jandem]]

And parts 4 + 5:

https://hg.mozilla.org/integration/mozilla-inbound/rev/abb6ce4a99cd
https://hg.mozilla.org/integration/mozilla-inbound/rev/fdfb57a0fe0b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/abb6ce4a99cd
https://hg.mozilla.org/mozilla-central/rev/fdfb57a0fe0b

Comment 12

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Jan de Mooij [:jandem] from comment #7)
> The --latin1-strings shell flag is still there but it's a NOP now. Gary,
> please let me know when I can remove it; I don't want to break the fuzzers
> while you're on PTO.

Thanks for the headsup! I've removed support for this in fuzzing rev 32e646e5cdc6. Please feel free to remove it.

Does the removal affect the aurora branch? I think the train has moved past one rapid release stop.

Comment 13

[Jan de Mooij [:jandem]]

(In reply to Gary Kwong [:gkw] [:nth10sd] PTO Jul 31 to Aug 01 from comment #12)
> Thanks for the headsup! I've removed support for this in fuzzing rev
> 32e646e5cdc6. Please feel free to remove it.
> 
> Does the removal affect the aurora branch? I think the train has moved past
> one rapid release stop.

Aurora will still have the shell flag, but it's a no-op there as well, because Latin1 strings are enabled anyway.

Comment 14

[Jan de Mooij [:jandem]]

Attachment: Part 6 - Remove flag

Comment 15

[Jan de Mooij [:jandem]]

Part 6:

https://hg.mozilla.org/integration/mozilla-inbound/rev/afeb3d37ce5d

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/afeb3d37ce5d

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/afeb3d37ce5d