Closed
Bug 1041493
Opened 10 years ago
Closed 10 years ago
add support for "browser" to mediaSource constraint
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: blassey, Assigned: blassey)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
10.07 KB,
patch
|
jesup
:
review+
khuey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8459537 -
Flags: review?(rjesup)
Comment 1•10 years ago
|
||
Comment on attachment 8459537 [details] [diff] [review] browser_mediaSource.patch Review of attachment 8459537 [details] [diff] [review]: ----------------------------------------------------------------- r+ as a patch so far as it goes. Larger question is what we're using this for; what it does on desktop, what's the UI bug for this; mods to MediaManager.cpp to provide info about "browser" being in-use for UI purposes, etc. So this is only part of the overall solution it seems. There should be a UI/UX bug(s) linked to this as well, plus probably security discussion. ::: dom/webidl/Constraints.webidl @@ +18,5 @@ > "camera", > "screen", > "application", > + "window", > + "browser" DOM peer needs to r+ this ::: dom/webidl/MediaTrackConstraintSet.webidl @@ +38,4 @@ > > // TODO: Bug 767924 sequences in unions > //typedef (VideoFacingModeEnum or sequence<VideoFacingModeEnum>) ConstrainVideoFacingMode; > +//typedef (MediaSourceEnum or sequence<MediaSourceEnum>) ConstrainMediaSource; Did this change? ::: media/webrtc/trunk/webrtc/video_engine/browser_capture_impl.h @@ +11,5 @@ > + public: > + virtual uint32_t NumberOfDevices() { return 1; } > + > + virtual int32_t GetDeviceName( > + uint32_t deviceNumber, Remove spurious line break (here and below) - is there some editor that encourages this format? @@ +16,5 @@ > + char* deviceNameUTF8, > + uint32_t deviceNameLength, > + char* deviceUniqueIdUTF8, > + uint32_t deviceUniqueIdUTF8Length, > + char* productUniqueIdUTF8 = 0, NULL
Attachment #8459537 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #1) > Comment on attachment 8459537 [details] [diff] [review] > browser_mediaSource.patch > > Review of attachment 8459537 [details] [diff] [review]: > ----------------------------------------------------------------- > > r+ as a patch so far as it goes. Larger question is what we're using this > for; what it does on desktop, what's the UI bug for this; mods to > MediaManager.cpp to provide info about "browser" being in-use for UI > purposes, etc. So this is only part of the overall solution it seems. > There should be a UI/UX bug(s) linked to this as well, plus probably > security discussion. The feature driving this is tab mirroring, which I'm working on in bug 1037015. > > ::: media/webrtc/trunk/webrtc/video_engine/browser_capture_impl.h > @@ +11,5 @@ > > + public: > > + virtual uint32_t NumberOfDevices() { return 1; } > > + > > + virtual int32_t GetDeviceName( > > + uint32_t deviceNumber, > > Remove spurious line break (here and below) - is there some editor that > encourages this format? No. I can't really explain these really.
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8459537 [details] [diff] [review] browser_mediaSource.patch r?khuey for the webidl change
Attachment #8459537 -
Flags: review?(khuey)
Attachment #8459537 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 4•10 years ago
|
||
this landed http://hg.mozilla.org/mozilla-central/rev/3a53a1cc3dbf
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Assignee: nobody → blassey.bugs
Target Milestone: --- → mozilla34
Updated•10 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•