add support for "browser" to mediaSource constraint

RESOLVED FIXED in mozilla34

Status

()

Core
WebRTC: Audio/Video
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

(Blocks: 1 bug, {dev-doc-needed})

unspecified
mozilla34
x86
Mac OS X
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8459537 [details] [diff] [review]
browser_mediaSource.patch
Attachment #8459537 - Flags: review?(rjesup)
Comment on attachment 8459537 [details] [diff] [review]
browser_mediaSource.patch

Review of attachment 8459537 [details] [diff] [review]:
-----------------------------------------------------------------

r+ as a patch so far as it goes.  Larger question is what we're using this for; what it does on desktop, what's the UI bug for this; mods to MediaManager.cpp to provide info about "browser" being in-use for UI purposes, etc.  So this is only part of the overall solution it seems.  There should be a UI/UX bug(s) linked to this as well, plus probably security discussion.

::: dom/webidl/Constraints.webidl
@@ +18,5 @@
>      "camera",
>      "screen",
>      "application",
> +    "window",
> +    "browser"

DOM peer needs to r+ this

::: dom/webidl/MediaTrackConstraintSet.webidl
@@ +38,4 @@
>  
>  // TODO: Bug 767924 sequences in unions
>  //typedef (VideoFacingModeEnum or sequence<VideoFacingModeEnum>) ConstrainVideoFacingMode;
> +//typedef (MediaSourceEnum or sequence<MediaSourceEnum>) ConstrainMediaSource;

Did this change?

::: media/webrtc/trunk/webrtc/video_engine/browser_capture_impl.h
@@ +11,5 @@
> +  public:
> +    virtual uint32_t NumberOfDevices() { return 1; }
> +
> +    virtual int32_t GetDeviceName(
> +                                  uint32_t deviceNumber,

Remove spurious line break (here and below) - is there some editor that encourages this format?

@@ +16,5 @@
> +                                  char* deviceNameUTF8,
> +                                  uint32_t deviceNameLength,
> +                                  char* deviceUniqueIdUTF8,
> +                                  uint32_t deviceUniqueIdUTF8Length,
> +                                  char* productUniqueIdUTF8 = 0,

NULL
Attachment #8459537 - Flags: review?(rjesup) → review+
(In reply to Randell Jesup [:jesup] from comment #1)
> Comment on attachment 8459537 [details] [diff] [review]
> browser_mediaSource.patch
> 
> Review of attachment 8459537 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ as a patch so far as it goes.  Larger question is what we're using this
> for; what it does on desktop, what's the UI bug for this; mods to
> MediaManager.cpp to provide info about "browser" being in-use for UI
> purposes, etc.  So this is only part of the overall solution it seems. 
> There should be a UI/UX bug(s) linked to this as well, plus probably
> security discussion.
The feature driving this is tab mirroring, which I'm working on in bug 1037015.


> 
> ::: media/webrtc/trunk/webrtc/video_engine/browser_capture_impl.h
> @@ +11,5 @@
> > +  public:
> > +    virtual uint32_t NumberOfDevices() { return 1; }
> > +
> > +    virtual int32_t GetDeviceName(
> > +                                  uint32_t deviceNumber,
> 
> Remove spurious line break (here and below) - is there some editor that
> encourages this format?

No. I can't really explain these really.
Comment on attachment 8459537 [details] [diff] [review]
browser_mediaSource.patch

r?khuey for the webidl change
Attachment #8459537 - Flags: review?(khuey)
(Assignee)

Updated

4 years ago
Blocks: 1037015
(Assignee)

Updated

4 years ago
Blocks: 1048335
this landed http://hg.mozilla.org/mozilla-central/rev/3a53a1cc3dbf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → blassey.bugs
Target Milestone: --- → mozilla34
Keywords: dev-doc-needed
Blocks: 1050930
You need to log in before you can comment on or make changes to this bug.